Re: [PATCH 3.14 21/29] netfilter: x_tables: validate targets of jumps

Florian Westphal
2016-06-23T08:54:58Z

Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 3.14-stable review patch. If anyone has any objections, please let me know.

I have -- this doesn't work in 3.14 as t->entries (the ruleset blob)
is still kept percpu.

> +static bool find_jump_target(const struct xt_table_info *t,
> + const struct arpt_entry *target)
> +{
> + struct arpt_entry *iter;
> +
> + xt_entry_foreach(iter, t->entries, t->size) {

.. so this causes in kernel soft lockup when I try to insert a rule.

I will go over the 3.14 stable queue and see if I can amend this to work
with 3.14.