From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751273AbcFXI6D (ORCPT ); Fri, 24 Jun 2016 04:58:03 -0400 Received: from mail.us.es ([193.147.175.20]:41460 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbcFXI57 (ORCPT ); Fri, 24 Jun 2016 04:57:59 -0400 Date: Fri, 24 Jun 2016 10:57:52 +0200 From: Pablo Neira Ayuso To: Joe Perches Cc: Patrick McHardy , Jozsef Kadlecsik , Stephen Hemminger , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening Message-ID: <20160624085752.GB1939@salvia> References: <20160623173659.GA3474@salvia> <1466708400.1847.15.camel@perches.com> <20160624085128.GA1939@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160624085128.GA1939@salvia> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2016 at 10:51:28AM +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 23, 2016 at 12:00:00PM -0700, Joe Perches wrote: > > On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > > > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > > > > > There is code duplication of a masked ethernet address comparison here > > > > so make it a separate function instead. > > > > > > > > Miscellanea: > > > > > > > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > > > Applied, thanks. > > > > > > > > > > > Signed-off-by: Joe Perches > > > > --- > > > > > > > > This masked_ether_addr_equal function could go into etherdevice.h, > > > > but I don't see another use like it in kernel code.  Is there one? > > > > > > This is specific of iptables, not even nftables would use this. So I > > > would keep this in the iptables tree. > > > > Did you see the other patch that adds a generic > > ether_addr_equal_masked() and uses it in a few > > more files? > > You mean this one: > > http://patchwork.ozlabs.org/patch/636208/ > > OK, so I'll toss the previous and will take this one instead. > > As I said my opinion is that ether_addr_equal_masked() is only > required by netfilter, but thinking it well I don't really mind in > what header this function is placed given that these are our internal > headers. git am reports patch I get from patchwork is corrupt at line 37. Tried a couple of tricks to fix it but this didn't work. Would you mind resubmitting this patch? Sorry for the inconvenience.