From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-security-module@vger.kernel.org,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()
Date: Fri, 24 Jun 2016 13:30:24 -0600 [thread overview]
Message-ID: <20160624193024.GA563@obsidianresearch.com> (raw)
In-Reply-To: <1466197847-4937-2-git-send-email-jarkko.sakkinen@linux.intel.com>
On Fri, Jun 17, 2016 at 11:10:43PM +0200, Jarkko Sakkinen wrote:
> extern int tpm_get_timeouts(struct tpm_chip *);
> -extern void tpm_gen_interrupt(struct tpm_chip *);
> +void tpm_gen_interrupt(struct tpm_chip *);
Dropping the argument name is not the kernel standard, if these lines
are going to be churned they may as well be churned to the standard.
FWIW, all the extern's should be dropped too.
Jason
next prev parent reply other threads:[~2016-06-24 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 21:10 [PATCH 0/5] Use tpm_transmit_cmd() consistently Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 1/5] tpm: unify tpm_gen_interrupt() Jarkko Sakkinen
2016-06-24 19:30 ` Jason Gunthorpe [this message]
2016-06-24 20:25 ` Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 2/5] tpm: return error code from tpm_gen_interrupt() Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 3/5] tpm: use tpm_transmit_cmd() in tpm2_probe() Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 4/5] tpm: rename tpm_pcr_read_dev() to tpm1_pcr_read() Jarkko Sakkinen
2016-06-17 21:10 ` [PATCH 5/5] tpm: use tpm1_pcr_read() in tpm_do_selftest() Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624193024.GA563@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).