From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751132AbcFXTai (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Jun 2016 15:30:38 -0400
Received: from quartz.orcorp.ca ([184.70.90.242]:51268 "EHLO quartz.orcorp.ca"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750876AbcFXTah (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Jun 2016 15:30:37 -0400
Date: Fri, 24 Jun 2016 13:30:24 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, linux-security-module@vger.kernel.org,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        Marcel Selhorst <tpmdd@selhorst.net>,
        "moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@lists.sourceforge.net>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] tpm: unify tpm_gen_interrupt()
Message-ID: <20160624193024.GA563@obsidianresearch.com>
References: <1466197847-4937-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <1466197847-4937-2-git-send-email-jarkko.sakkinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466197847-4937-2-git-send-email-jarkko.sakkinen@linux.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 17, 2016 at 11:10:43PM +0200, Jarkko Sakkinen wrote:
>  extern int tpm_get_timeouts(struct tpm_chip *);
> -extern void tpm_gen_interrupt(struct tpm_chip *);
> +void tpm_gen_interrupt(struct tpm_chip *);

Dropping the argument name is not the kernel standard, if these lines
are going to be churned they may as well be churned to the standard.

FWIW, all the extern's should be dropped too.

Jason