From: Richard Cochran <richardcochran@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Eric Dumazet <edumazet@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Chris Mason <clm@fb.com>, Arjan van de Ven <arjan@infradead.org>,
rt@linutronix.de, Rik van Riel <riel@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
George Spelvin <linux@sciencehorizons.net>,
Len Brown <lenb@kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [patch V3 19/22] timer: Forward wheel clock whenever possible
Date: Fri, 24 Jun 2016 22:45:20 +0200 [thread overview]
Message-ID: <20160624204519.GA13368@netboy> (raw)
In-Reply-To: <20160624141723.016280325@linutronix.de>
On Fri, Jun 24, 2016 at 02:32:19PM -0000, Thomas Gleixner wrote:
> @@ -809,6 +815,12 @@ static void tick_nohz_restart_sched_tick
> tick_do_update_jiffies64(now);
> cpu_load_update_nohz_stop();
>
> + /*
> + * Clear the timer idle flag, so we avoid IPIs on remote queueing and
> + * the clock forward checks in the enqueue path.
> + */
> + timer_clear_idle();
Since function calls timer_clear_idle() already ...
> calc_load_exit_idle();
> touch_softlockup_watchdog_sched();
> /*
> @@ -1025,6 +1037,7 @@ void tick_nohz_idle_exit(void)
> tick_nohz_stop_idle(ts, now);
>
> if (ts->tick_stopped) {
> + timer_clear_idle();
> tick_nohz_restart_sched_tick(ts, now);
> tick_nohz_account_idle_ticks(ts);
> }
... there is no need to call timer_clear_idle() here.
Thanks,
Richard
next prev parent reply other threads:[~2016-06-24 20:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:32 [patch V3 00/22] timer: Refactor the timer wheel Thomas Gleixner
2016-06-24 14:32 ` [patch V3 01/22] timer: Make pinned a timer property Thomas Gleixner
2016-07-01 13:03 ` Frederic Weisbecker
2016-06-24 14:32 ` [patch V3 02/22] x86/apic/uv: Initialize timer as pinned Thomas Gleixner
2016-06-24 14:32 ` [patch V3 03/22] x86/mce: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 04/22] cpufreq/powernv: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 05/22] driver/net/ethernet/tile: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 06/22] drivers/tty/metag_da: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 07/22] drivers/tty/mips_ejtag: " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 08/22] net/ipv4/inet: Initialize timers " Thomas Gleixner
2016-06-24 14:32 ` [patch V3 09/22] timer: Remove mod_timer_pinned Thomas Gleixner
2016-06-24 14:32 ` [patch V3 10/22] signal: Use hrtimer for sigtimedwait Thomas Gleixner
2016-06-24 14:32 ` [patch V3 11/22] hlist: Add hlist_is_singular_node() helper Thomas Gleixner
2016-06-24 14:32 ` [patch V3 12/22] timer: Give a few structs and members proper names Thomas Gleixner
2016-06-24 14:32 ` [patch V3 13/22] timer: Reduce the CPU index space to 256k Thomas Gleixner
2016-07-01 14:41 ` Frederic Weisbecker
2016-06-24 14:32 ` [patch V3 14/22] timer: Switch to a non cascading wheel Thomas Gleixner
2016-06-24 14:32 ` [patch V3 15/22] timer: Remove slack leftovers Thomas Gleixner
2016-06-24 14:32 ` [patch V3 16/22] timer: Move __run_timers() function Thomas Gleixner
2016-06-24 14:32 ` [patch V3 17/22] timer: Optimize collect timers for NOHZ Thomas Gleixner
2016-06-24 14:32 ` [patch V3 18/22] tick/sched: Remove pointless empty function Thomas Gleixner
2016-06-24 14:32 ` [patch V3 19/22] timer: Forward wheel clock whenever possible Thomas Gleixner
2016-06-24 20:45 ` Richard Cochran [this message]
2016-06-25 8:55 ` Thomas Gleixner
2016-06-24 14:32 ` [patch V3 20/22] timer: Only wake softirq if necessary Thomas Gleixner
2016-06-24 14:32 ` [patch V3 21/22] timer: Split out index calculation Thomas Gleixner
2016-06-24 14:32 ` [patch V3 22/22] timer: Optimization for same expiry time in mod_timer() Thomas Gleixner
2016-06-24 17:04 ` [patch V3 00/22] timer: Refactor the timer wheel Josh Triplett
2016-06-27 4:22 ` Paul E. McKenney
2016-06-27 23:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624204519.GA13368@netboy \
--to=richardcochran@gmail.com \
--cc=arjan@infradead.org \
--cc=clm@fb.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sciencehorizons.net \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rt@linutronix.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).