From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbcFYHQh (ORCPT ); Sat, 25 Jun 2016 03:16:37 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47086 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751081AbcFYHQf (ORCPT ); Sat, 25 Jun 2016 03:16:35 -0400 Date: Sat, 25 Jun 2016 09:16:33 +0200 From: Maxime Ripard To: megous@megous.com Cc: dev@linux-sunxi.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Russell King , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v2 10/14] ARM: dts: sun8i: Add r_twi I2C controller Message-ID: <20160625071633.GD4000@lukather> References: <20160625034511.7966-1-megous@megous.com> <20160625034511.7966-11-megous@megous.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kvUQC+jR9YzypDnK" Content-Disposition: inline In-Reply-To: <20160625034511.7966-11-megous@megous.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kvUQC+jR9YzypDnK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Jun 25, 2016 at 05:45:07AM +0200, megous@megous.com wrote: > From: Ondrej Jirman >=20 > H3 SoC contains I2C controller optionally available > on the PL0 and PL1 pins. This patch makes this controller > available. >=20 > Signed-off-by: Ondrej Jirman > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3= =2Edtsi > index 56f211e..e32f211 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -322,8 +322,9 @@ > reg =3D <0x01f01428 0x4>; > #clock-cells =3D <1>; > clocks =3D <&apb0>; > - clock-indices =3D <0>, <1>; > - clock-output-names =3D "apb0_pio", "apb0_ir"; > + clock-indices =3D <0>, <1>, <6>; > + clock-output-names =3D "apb0_pio", "apb0_ir", "apb0_i2c"; > + The new line is not needed, and it should be part of a separate patch. > }; > =20 > ir_clk: ir_clk@01f01454 { > @@ -656,6 +657,20 @@ > status =3D "disabled"; > }; > =20 > + r_twi: i2c@01f02400 { We call it i2c everywhere, please call it that way too. > + compatible =3D "allwinner,sun6i-a31-i2c"; > + reg =3D <0x01f02400 0x400>; > + interrupts =3D ; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&r_twi_pins_a>; > + clocks =3D <&apb0_gates 6>; > + clock-frequency =3D <100000>; > + resets =3D <&apb0_reset 6>; > + status =3D "disabled"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + }; > + > gic: interrupt-controller@01c81000 { > compatible =3D "arm,cortex-a7-gic", "arm,cortex-a15-gic"; > reg =3D <0x01c81000 0x1000>, > @@ -707,6 +722,13 @@ > allwinner,drive =3D ; > allwinner,pull =3D ; > }; > + > + r_twi_pins_a: r_twi@0 { > + allwinner,pins =3D "PL0", "PL1"; > + allwinner,function =3D "s_twi"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; Separate patch please. Thanks! --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --kvUQC+jR9YzypDnK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXbi/RAAoJEBx+YmzsjxAg110QALJdQ96hoQVAezokdmai9a3B YMvrMQ4QFfJjSafH/1wJzupuJmGb1wwjBilIlTrswzIeM/i4uDQvgLYcSMn4WV9R twdtwCNnBxv8jrNIo7fKAVgYSGXAEqvIWKmn8XymCtOGwyE6SKK9p3zYT5mZboRT yxOUijCQrHLtk1NK7jF9Qy+gc6hRIHxA8nm5l3NG3Wfe93ExipmO/U6SnFMebKXb SPb7paFaWIoM2rFmGe7GZWtO2WXGaQyw9/O0OwWxE3YEYZcRqGfVGnycdYx9VNOy sj/XwEpFrmCwg3gHi/rhn1vu6ISvOatqe9iHHaGG8GV0hzowvelF5ZaisrR3hXPy girwcNwg3m+fQet9BKz9+/vQ5jQFJCmS2hkf0ktKAVJNrfFowL/FMNOR2oas7XX2 NrEkP8sM5QrMn0siI0r77sefat1m9b3XdRZd5+ju+5L/5l11EeUy/31V7pFS3+Ie vDGcLMYRMkmkPdslS/Cv/SUIH3ayq/NmlRX6D4MhEU5n/1KEFBv5d5vzWF60Eauh 2JDSlKKWA936AdBN+L6VdkDU34oF5+HUpt5VK/Yb+EuYNTAria+vYH7LIV9ArALP OdQd8q6211dqQ7LEfnTlXahQJPQGJkMNTRJ4d0CQXvRdE8+yqGxQX64Md7sV/Tli mnkTKP4iHBpQTfCAznaj =2sZm -----END PGP SIGNATURE----- --kvUQC+jR9YzypDnK--