From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbcFYHSM (ORCPT ); Sat, 25 Jun 2016 03:18:12 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47148 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751081AbcFYHSL (ORCPT ); Sat, 25 Jun 2016 03:18:11 -0400 Date: Sat, 25 Jun 2016 09:18:09 +0200 From: Maxime Ripard To: megous@megous.com Cc: dev@linux-sunxi.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Russell King , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v2 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Message-ID: <20160625071808.GE4000@lukather> References: <20160625034511.7966-1-megous@megous.com> <20160625034511.7966-14-megous@megous.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zaRBsRFn0XYhEU69" Content-Disposition: inline In-Reply-To: <20160625034511.7966-14-megous@megous.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zaRBsRFn0XYhEU69 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 25, 2016 at 05:45:10AM +0200, megous@megous.com wrote: > From: Ondrej Jirman >=20 > Xulong Orange Pi One uses GPIO based regulator that > switches between two voltages: 1.1V and 1.3V. The > regulator is controlled from the PL6 pin. >=20 > Signed-off-by: Ondrej Jirman > --- > v2 > - add missing pinctrl-names for gpio-regulator > --- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 +++++++++++++++++++++++= +++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/= dts/sun8i-h3-orangepi-one.dts > index 0adf932..b1bd6b0 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > @@ -88,6 +88,25 @@ > gpios =3D <&r_pio 0 3 GPIO_ACTIVE_LOW>; > }; > }; > + > + vdd_soc: gpio-regulator { > + compatible =3D "regulator-gpio"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&vdd_reg_r_opc>; > + > + regulator-name =3D "soc-vdd-supply"; > + regulator-min-microvolt =3D <1100000>; > + regulator-max-microvolt =3D <1300000>; > + regulator-boot-on; > + regulator-type =3D "voltage"; It should be marked as always-on. Otherwise, if the cpufreq driver is not enabled, the regulator will be shutdown, which is not that great :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --zaRBsRFn0XYhEU69 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXbjAwAAoJEBx+YmzsjxAgyaoP/09mHG862YnRLYccxIJAn5Fv pN6O8N6NYab9JAdA0HjEbtyVViGPIRDMuYkrk9ZLV3JP2cP5RInmNvI+18XuEOVa QdRNNRXTfCeapUY3atIEdcKNA4aL3KMJtS2zNOX7yFTXJ3l2aaO9vHVYniazwUf1 fZfVgDjVMHSAeWRFV0dfwpO7lnq6fVkICcaiOMqfs3u9cMvD/Pe+ER6sccYjUQGJ Ek481fpRSy/7dJ8CRbSjtUyiJCITy+bqnW6fXwNpyyuKj27R5JLLAMkk0OmAG7yH gVUOV/jneIuUx8oQBe4AEMi8QDPb9MEuPhfTPo3ndD+21a0rZ+vxXT3iBliFn6tt HF9F4NVG7h9YzO3YmCR4Z87L9oqbkiQRscAPpvtLiCT6PKltFWwaVIeln1FGm49B bmpF5IDwyV0afUVTjayJl29xQiOxj+XYvL2G4VAkDRQpvTYZbGudLGqL+g2eF0pw 118cfJP2J984+fJHd0n0QjP2heTstme4tgBlNta7744/8QTqAAyNiqju/YITxVr4 8j+20YBFjgfqpnLuwHlRaQ/J+VPFGJegDJcTep4FXa4cm6Bsfg7H0I3WgTW7maZI hwvr9eCf0s5GF7/rfzJowrvHfYO5t4hIdsegtYgj7Kt7umt/QOV7mvnlzA0tUAtp 4xYYMZaNCIxcp3UyrOrG =v0Oe -----END PGP SIGNATURE----- --zaRBsRFn0XYhEU69--