From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbcF0OH2 (ORCPT ); Mon, 27 Jun 2016 10:07:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:23650 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbcF0OH0 (ORCPT ); Mon, 27 Jun 2016 10:07:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,536,1459839600"; d="scan'208";a="984093945" Date: Mon, 27 Jun 2016 17:04:45 +0300 From: Jarkko Sakkinen To: Sudip Mukherjee Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm: use devm_add_action_or_reset Message-ID: <20160627140445.GA1233@intel.com> References: <1465740329-4699-1-git-send-email-sudipm.mukherjee@gmail.com> <20160616202823.GE1414@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160616202823.GE1414@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 10:28:23PM +0200, Jarkko Sakkinen wrote: > On Sun, Jun 12, 2016 at 03:05:29PM +0100, Sudip Mukherjee wrote: > > If devm_add_action() fails we are explicitly calling put_device() to > > free the resources allocated. Lets use the helper > > devm_add_action_or_reset() and return directly in case of error, as we > > know that the cleanup function has been already called by the helper if > > there was any error. > > > > Signed-off-by: Sudip Mukherjee > > Reviewed-by: Jarkko Sakkinen Applied to master. /Jarkko