From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbcF0Ozm (ORCPT ); Mon, 27 Jun 2016 10:55:42 -0400 Received: from foss.arm.com ([217.140.101.70]:40692 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbcF0Ozk (ORCPT ); Mon, 27 Jun 2016 10:55:40 -0400 Date: Mon, 27 Jun 2016 15:54:46 +0100 From: Mark Rutland To: Hans de Goede Cc: Russell King - ARM Linux , Marc Zyngier , Linux Kernel Mailing List , Chen-Yu Tsai , Maxime Ripard , Thomas Gleixner , linux-arm-kernel Subject: Re: BUG?: kernel does not (re)set irq smp_affinity to reboot_cpu Message-ID: <20160627145445.GA29321@leverpostej> References: <4dc8bd4c-8456-9f94-b7eb-c5d227ddc673@redhat.com> <5770EE21.90103@arm.com> <20160627094552.GE1041@n2100.armlinux.org.uk> <20160627113143.GF1041@n2100.armlinux.org.uk> <842a453d-3295-ffbd-f3dd-67baba1692d2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <842a453d-3295-ffbd-f3dd-67baba1692d2@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2016 at 02:53:16PM +0200, Hans de Goede wrote: > Note this does not mean that all pm_power_off implementations > are going to be happy with machine_power_off leaving irqs > enabled, I would esp. expect the efi and psci implementations > to potentially be unhappy about this. See below for a proposal > to deal with this. Neither PSCI nor EFI care either way about interrupts. PSCI makes synchronous HVC/SMC calls to a higher exception level, and can be safely called with interrupts enabled or disabled. EFI's ResetSystem (which backs pm_power_off) can be called with interrupts enabled or disabled, so long as there is not a clashing call in progress already (see 7.1 "Runtime Services Rules and Restrictions") in the EFI 2.6 spec. Thanks, Mark.