From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: arizona: Add missing disable of PM runtime on probe error path
Date: Mon, 27 Jun 2016 16:04:24 +0100 [thread overview]
Message-ID: <20160627150424.GA6720@dell> (raw)
In-Reply-To: <1467037151-23765-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, 27 Jun 2016, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/arizona-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index bf27179..e4f97b3 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1462,7 +1462,7 @@ int arizona_dev_init(struct arizona *arizona)
> /* Set up for interrupts */
> ret = arizona_irq_init(arizona);
> if (ret != 0)
> - goto err_reset;
> + goto err_pm;
>
> pm_runtime_set_autosuspend_delay(arizona->dev, 100);
> pm_runtime_use_autosuspend(arizona->dev);
> @@ -1486,6 +1486,8 @@ int arizona_dev_init(struct arizona *arizona)
>
> err_irq:
> arizona_irq_exit(arizona);
> +err_pm:
> + pm_runtime_disable(arizona->dev);
> err_reset:
> arizona_enable_reset(arizona);
> regulator_disable(arizona->dcvdd);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-06-27 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 14:19 [PATCH] mfd: arizona: Add missing disable of PM runtime on probe error path Charles Keepax
2016-06-27 15:04 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627150424.GA6720@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).