From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: neerajbadlani@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [perf]: update makefile message for installing required libs
Date: Mon, 27 Jun 2016 12:34:38 -0300 [thread overview]
Message-ID: <20160627153438.GC3324@kernel.org> (raw)
In-Reply-To: <1467035997-9100-1-git-send-email-neerajbadlani@gmail.com>
Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@gmail.com escreveu:
> From: Neeraj Badlani <neerajbadlani@gmail.com>
>
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
>
> Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
> ---
> tools/perf/config/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>
> ifndef NO_SLANG
> ifneq ($(feature-libslang), 1)
> - msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> + msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
Too many 'or', I'll apply it as:
+ msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);
Thanks,
- Arnaldo
> NO_SLANG := 1
> else
> # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> --
> 2.7.4
next prev parent reply other threads:[~2016-06-27 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 13:59 [PATCH] [perf]: update makefile message for installing required libs neerajbadlani
2016-06-27 15:34 ` Arnaldo Carvalho de Melo [this message]
2016-06-29 9:41 ` [tip:perf/core] perf tools: Update makefile message for installing slang devel package tip-bot for Neeraj Badlani
-- strict thread matches above, loose matches on Subject: below --
2016-06-27 7:10 [PATCH] [perf]: update makefile message for installing required libs neerajbadlani
2016-06-27 8:11 ` Peter Zijlstra
2016-06-27 4:49 neerajbadlani
2016-06-27 6:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627153438.GC3324@kernel.org \
--to=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neerajbadlani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).