From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751857AbcF0Peo (ORCPT ); Mon, 27 Jun 2016 11:34:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:46270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcF0Pen (ORCPT ); Mon, 27 Jun 2016 11:34:43 -0400 Date: Mon, 27 Jun 2016 12:34:38 -0300 From: Arnaldo Carvalho de Melo To: neerajbadlani@gmail.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] [perf]: update makefile message for installing required libs Message-ID: <20160627153438.GC3324@kernel.org> References: <1467035997-9100-1-git-send-email-neerajbadlani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467035997-9100-1-git-send-email-neerajbadlani@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@gmail.com escreveu: > From: Neeraj Badlani > > In case of missing library (libslang), give hint to install library (libslang2-dev) > Since libslang-dev is not provided by Ubuntu's apt-package > > Signed-off-by: Neeraj Badlani > --- > tools/perf/config/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 5ad0255..e57d4d7 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -437,7 +437,7 @@ endif > > ifndef NO_SLANG > ifneq ($(feature-libslang), 1) > - msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev); > + msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev); Too many 'or', I'll apply it as: + msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev); Thanks, - Arnaldo > NO_SLANG := 1 > else > # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h > -- > 2.7.4