* [PATCH] [perf]: update makefile message for installing required libs
@ 2016-06-27 13:59 neerajbadlani
2016-06-27 15:34 ` Arnaldo Carvalho de Melo
2016-06-29 9:41 ` [tip:perf/core] perf tools: Update makefile message for installing slang devel package tip-bot for Neeraj Badlani
0 siblings, 2 replies; 7+ messages in thread
From: neerajbadlani @ 2016-06-27 13:59 UTC (permalink / raw)
To: acme; +Cc: Neeraj Badlani, linux-kernel
From: Neeraj Badlani <neerajbadlani@gmail.com>
In case of missing library (libslang), give hint to install library (libslang2-dev)
Since libslang-dev is not provided by Ubuntu's apt-package
Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 5ad0255..e57d4d7 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -437,7 +437,7 @@ endif
ifndef NO_SLANG
ifneq ($(feature-libslang), 1)
- msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
+ msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
NO_SLANG := 1
else
# Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] [perf]: update makefile message for installing required libs
2016-06-27 13:59 [PATCH] [perf]: update makefile message for installing required libs neerajbadlani
@ 2016-06-27 15:34 ` Arnaldo Carvalho de Melo
2016-06-29 9:41 ` [tip:perf/core] perf tools: Update makefile message for installing slang devel package tip-bot for Neeraj Badlani
1 sibling, 0 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-06-27 15:34 UTC (permalink / raw)
To: neerajbadlani; +Cc: linux-kernel
Em Mon, Jun 27, 2016 at 06:59:57AM -0700, neerajbadlani@gmail.com escreveu:
> From: Neeraj Badlani <neerajbadlani@gmail.com>
>
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
>
> Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
> ---
> tools/perf/config/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>
> ifndef NO_SLANG
> ifneq ($(feature-libslang), 1)
> - msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> + msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
Too many 'or', I'll apply it as:
+ msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);
Thanks,
- Arnaldo
> NO_SLANG := 1
> else
> # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> --
> 2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip:perf/core] perf tools: Update makefile message for installing slang devel package
2016-06-27 13:59 [PATCH] [perf]: update makefile message for installing required libs neerajbadlani
2016-06-27 15:34 ` Arnaldo Carvalho de Melo
@ 2016-06-29 9:41 ` tip-bot for Neeraj Badlani
1 sibling, 0 replies; 7+ messages in thread
From: tip-bot for Neeraj Badlani @ 2016-06-29 9:41 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, hpa, mingo, neerajbadlani, acme, linux-kernel
Commit-ID: 9f776ba11c8be311a5c23777bc9f3b96498cc6cc
Gitweb: http://git.kernel.org/tip/9f776ba11c8be311a5c23777bc9f3b96498cc6cc
Author: Neeraj Badlani <neerajbadlani@gmail.com>
AuthorDate: Mon, 27 Jun 2016 06:59:57 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 27 Jun 2016 12:44:22 -0300
perf tools: Update makefile message for installing slang devel package
In case of missing library (libslang), give hint to install library
(libslang2-dev), since libslang-dev is not provided by Ubuntu.
Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
Link: http://lkml.kernel.org/r/1467035997-9100-1-git-send-email-neerajbadlani@gmail.com
[ removed excessive 'or' usage ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 534c811..bf1a0a0 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -482,7 +482,7 @@ endif
ifndef NO_SLANG
ifneq ($(feature-libslang), 1)
- msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
+ msg := $(warning slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev);
NO_SLANG := 1
else
# Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] [perf]: update makefile message for installing required libs
@ 2016-06-27 7:10 neerajbadlani
2016-06-27 8:11 ` Peter Zijlstra
0 siblings, 1 reply; 7+ messages in thread
From: neerajbadlani @ 2016-06-27 7:10 UTC (permalink / raw)
To: peterz; +Cc: linux-kernel, Neeraj Badlani
From: Neeraj Badlani <neerajbadlani@gmail.com>
In case of missing library (libslang), give hint to install library (libslang2-dev)
Since libslang-dev is not provided by Ubuntu's apt-package
Signed-off-by: Neeraj Badlani <neerajbadlani@gmail.com>
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 5ad0255..e57d4d7 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -437,7 +437,7 @@ endif
ifndef NO_SLANG
ifneq ($(feature-libslang), 1)
- msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
+ msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
NO_SLANG := 1
else
# Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] [perf]: update makefile message for installing required libs
@ 2016-06-27 4:49 neerajbadlani
2016-06-27 6:26 ` Peter Zijlstra
0 siblings, 1 reply; 7+ messages in thread
From: neerajbadlani @ 2016-06-27 4:49 UTC (permalink / raw)
To: peterz; +Cc: mingo, linux-kernel, Neeraj Badlani
From: Neeraj Badlani <neerajbadlani@gmail.com>
In case of missing library (libslang), give hint to install library (libslang2-dev)
Since libslang-dev is not provided by Ubuntu's apt-package
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 5ad0255..e57d4d7 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -437,7 +437,7 @@ endif
ifndef NO_SLANG
ifneq ($(feature-libslang), 1)
- msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
+ msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
NO_SLANG := 1
else
# Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] [perf]: update makefile message for installing required libs
2016-06-27 4:49 neerajbadlani
@ 2016-06-27 6:26 ` Peter Zijlstra
0 siblings, 0 replies; 7+ messages in thread
From: Peter Zijlstra @ 2016-06-27 6:26 UTC (permalink / raw)
To: neerajbadlani; +Cc: mingo, linux-kernel, Arnaldo Carvalho de Melo
On Sun, Jun 26, 2016 at 09:49:56PM -0700, neerajbadlani@gmail.com wrote:
> From: Neeraj Badlani <neerajbadlani@gmail.com>
>
> In case of missing library (libslang), give hint to install library (libslang2-dev)
> Since libslang-dev is not provided by Ubuntu's apt-package
No Signed-off-by:, so I (or in reality acme) cannot actually do anything
with this patch.
Please see Documentation/SubmittingPatches.
> ---
> tools/perf/config/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 5ad0255..e57d4d7 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -437,7 +437,7 @@ endif
>
> ifndef NO_SLANG
> ifneq ($(feature-libslang), 1)
> - msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev);
> + msg := $(warning slang not found, disables TUI support. Please install slang-devel or libslang-dev or libslang2-dev);
> NO_SLANG := 1
> else
> # Fedora has /usr/include/slang/slang.h, but ubuntu /usr/include/slang.h
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-29 9:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-27 13:59 [PATCH] [perf]: update makefile message for installing required libs neerajbadlani
2016-06-27 15:34 ` Arnaldo Carvalho de Melo
2016-06-29 9:41 ` [tip:perf/core] perf tools: Update makefile message for installing slang devel package tip-bot for Neeraj Badlani
-- strict thread matches above, loose matches on Subject: below --
2016-06-27 7:10 [PATCH] [perf]: update makefile message for installing required libs neerajbadlani
2016-06-27 8:11 ` Peter Zijlstra
2016-06-27 4:49 neerajbadlani
2016-06-27 6:26 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).