From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbcF1LTq (ORCPT ); Tue, 28 Jun 2016 07:19:46 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36901 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcF1LTo (ORCPT ); Tue, 28 Jun 2016 07:19:44 -0400 Date: Tue, 28 Jun 2016 12:14:02 +0100 From: Lee Jones To: Keerthy Cc: tony@atomide.com, broonie@kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, russ.dill@ti.com, Dave Gerlach Subject: Re: [PATCH v2 4/5] mfd: tps65218: add version check to the PMIC probe Message-ID: <20160628111402.GA24982@dell> References: <1466756892-17015-1-git-send-email-j-keerthy@ti.com> <1466756892-17015-4-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1466756892-17015-4-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jun 2016, Keerthy wrote: > From: Tero Kristo > > Version information will be needed to handle some error cases under the > regulator driver, so store the information once during MFD probe. > > Signed-off-by: Tero Kristo > Signed-off-by: Dave Gerlach > Signed-off-by: Keerthy > --- > drivers/mfd/tps65218.c | 9 +++++++++ > include/linux/mfd/tps65218.h | 1 + > 2 files changed, 10 insertions(+) Acked-by: Lee Jones > diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c > index 80b9dc3..ba610ad 100644 > --- a/drivers/mfd/tps65218.c > +++ b/drivers/mfd/tps65218.c > @@ -219,6 +219,7 @@ static int tps65218_probe(struct i2c_client *client, > struct tps65218 *tps; > const struct of_device_id *match; > int ret; > + unsigned int chipid; > > match = of_match_device(of_tps65218_match_table, &client->dev); > if (!match) { > @@ -250,6 +251,14 @@ static int tps65218_probe(struct i2c_client *client, > if (ret < 0) > return ret; > > + ret = tps65218_reg_read(tps, TPS65218_REG_CHIPID, &chipid); > + if (ret) { > + dev_err(tps->dev, "Failed to read chipid: %d\n", ret); > + return ret; > + } > + > + tps->rev = chipid & TPS65218_CHIPID_REV_MASK; > + > ret = of_platform_populate(client->dev.of_node, NULL, NULL, > &client->dev); > if (ret < 0) > diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h > index 7fdf532..85e464e 100644 > --- a/include/linux/mfd/tps65218.h > +++ b/include/linux/mfd/tps65218.h > @@ -267,6 +267,7 @@ struct tps_info { > struct tps65218 { > struct device *dev; > unsigned int id; > + u8 rev; > > struct mutex tps_lock; /* lock guarding the data structure */ > /* IRQ Data */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog