From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbcF1PbV (ORCPT ); Tue, 28 Jun 2016 11:31:21 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36556 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbcF1PbT (ORCPT ); Tue, 28 Jun 2016 11:31:19 -0400 Date: Tue, 28 Jun 2016 16:25:29 +0100 From: Lee Jones To: weiyj_lk@163.com Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mfd: hi655x: Fix return value check in hi655x_pmic_probe() Message-ID: <20160628152529.GA29166@dell> References: <1466270767-3888-1-git-send-email-weiyj_lk@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1466270767-3888-1-git-send-email-weiyj_lk@163.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Jun 2016, weiyj_lk@163.com wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). Also remove unneeded error handling of > platform_get_resource(). > > Signed-off-by: Wei Yongjun > --- > drivers/mfd/hi655x-pmic.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > index 05ddc78..58bf149 100644 > --- a/drivers/mfd/hi655x-pmic.c > +++ b/drivers/mfd/hi655x-pmic.c > @@ -80,12 +80,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev) > pmic->dev = dev; > > pmic->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!pmic->res) > - return -ENOENT; > - > base = devm_ioremap_resource(dev, pmic->res); > - if (!base) > - return -ENOMEM; > + if (IS_ERR(base)) > + return PTR_ERR(base); > > pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base, > &hi655x_regmap_config); > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog