From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752377AbcF1UCZ (ORCPT ); Tue, 28 Jun 2016 16:02:25 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59756 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbcF1UCY (ORCPT ); Tue, 28 Jun 2016 16:02:24 -0400 Date: Tue, 28 Jun 2016 22:02:19 +0200 From: Andrew Lunn To: Jon Mason Cc: zajec5@gmail.com, davem@davemloft.net, f.fainelli@gmail.com, hauke@hauke-m.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Message-ID: <20160628200219.GE16588@lunn.ch> References: <1467142484-11161-1-git-send-email-jon.mason@broadcom.com> <1467142484-11161-4-git-send-email-jon.mason@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467142484-11161-4-git-send-email-jon.mason@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2016 at 03:34:40PM -0400, Jon Mason wrote: > Move the BCMA MDIO phy into a separate file, as it is very tightly > coupled with the BCMA bus. This will help with the upcoming BCMA > removal from the bgmac driver. Optimally, this should be moved into > phy drivers, but it is too tightly coupled with the bgmac driver to > effectively move it without more changes to the driver. It is quite common to have the MII bus driver as a sub driver of the MAC driver, if they are tightly coupled. The MII drivers in drivers/net/phy are all independent of the MAC driver and use a different space in the register sets. This does not seem the case here, so i think the split you have made is O.K, and i don't see a need to move it into phy. Andrew