From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
LKP <lkp@01.org>, LKML <linux-kernel@vger.kernel.org>,
kernel test robot <xiaolong.ye@intel.com>
Subject: Re: kthread_stop insanity (Re: [[DEBUG] force] 2642458962: BUG: unable to handle kernel paging request at ffffc90000997f18)
Date: Tue, 28 Jun 2016 22:12:50 +0200 [thread overview]
Message-ID: <20160628201249.GA12471@redhat.com> (raw)
In-Reply-To: <CALCETrXP7S2JWFBswPtOrafPcugkM0+k-aWPbd_wjJd+iaiJ_Q@mail.gmail.com>
On 06/28, Andy Lutomirski wrote:
>
> On Tue, Jun 28, 2016 at 11:58 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > Then how (say) proc_pid_stack() can work? If it hits the task which is
> > alreay dead we are (probably) fine, valid_stack_ptr() should fail iiuc.
> >
> > But what if we race with the last schedule() ? "addr = *stack" can read
> > the already vfree'ed memory, no?
> >
> > Looks like print_context_stack/etc need probe_kernel_address or I missed
> > something.
>
> Yuck. I suppose I could add a reference count to protect the stack.
> Would that simplify the kthread code?
Well yes, that is why I asked. So please tell me if you are going to
do this...
But we can fix kthread code without this hack which we do not need in
the long term anyway. Unfortunaly we need to cleanup kernel/smpboot.c
first. And I was going to do this a long ago for quite different reason ;)
So please forget unless you see another reason for this change.
Oleg.
next prev parent reply other threads:[~2016-06-28 20:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 5:22 kthread_stop insanity (Re: [[DEBUG] force] 2642458962: BUG: unable to handle kernel paging request at ffffc90000997f18) Andy Lutomirski
2016-06-27 8:28 ` Peter Zijlstra
2016-06-27 14:54 ` Oleg Nesterov
2016-06-27 15:44 ` Andy Lutomirski
2016-06-27 17:00 ` Oleg Nesterov
2016-06-28 18:58 ` Oleg Nesterov
2016-06-28 19:12 ` Andy Lutomirski
2016-06-28 20:12 ` Oleg Nesterov [this message]
2016-06-28 20:54 ` Andy Lutomirski
2016-06-28 21:14 ` Linus Torvalds
2016-06-28 21:18 ` Linus Torvalds
2016-06-28 21:21 ` Andy Lutomirski
2016-06-28 21:35 ` Linus Torvalds
2016-06-28 21:40 ` Linus Torvalds
2016-06-28 22:47 ` Oleg Nesterov
2016-06-28 22:59 ` Oleg Nesterov
2016-06-29 15:34 ` Andy Lutomirski
2016-06-29 18:03 ` [PATCH] kthread: to_live_kthread() needs try_get_task_stack() Oleg Nesterov
2016-06-29 18:28 ` kbuild test robot
2016-06-29 18:44 ` Oleg Nesterov
2016-06-29 18:51 ` kbuild test robot
2016-06-29 23:01 ` Andy Lutomirski
2016-06-29 23:33 ` kthread_stop insanity (Re: [[DEBUG] force] 2642458962: BUG: unable to handle kernel paging request at ffffc90000997f18) Andy Lutomirski
2016-06-27 17:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628201249.GA12471@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).