From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbcF2KGI (ORCPT ); Wed, 29 Jun 2016 06:06:08 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:39699 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbcF2KGH (ORCPT ); Wed, 29 Jun 2016 06:06:07 -0400 Date: Wed, 29 Jun 2016 06:05:35 -0400 (EDT) Message-Id: <20160629.060535.1405302756445494902.davem@davemloft.net> To: tremyfr@gmail.com Cc: mw@semihalf.com, jszhang@marvell.com, amitoj1606@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: ethernet: mvpp2: use phy_ethtool_{get|set}_link_ksettings From: David Miller In-Reply-To: <1467065292-20996-2-git-send-email-tremyfr@gmail.com> References: <1467065292-20996-1-git-send-email-tremyfr@gmail.com> <1467065292-20996-2-git-send-email-tremyfr@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Jun 2016 03:06:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Reynes Date: Tue, 28 Jun 2016 00:08:12 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.