From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbcF2H0o (ORCPT ); Wed, 29 Jun 2016 03:26:44 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:42940 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbcF2H0n (ORCPT ); Wed, 29 Jun 2016 03:26:43 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Wed, 29 Jun 2016 16:27:08 +0900 From: Minchan Kim To: "Huang, Ying" CC: Andrew Morton , "Kirill A. Shutemov" , Jerome Marchand , Matthew Wilcox , Vlastimil Babka , Dan Williams , Mel Gorman , Andrea Arcangeli , Ebru Akagunduz , , Subject: Re: [PATCH 2/2] mm, THP: Clean up return value of madvise_free_huge_pmd Message-ID: <20160629072708.GC18523@bbox> References: <1467135452-16688-1-git-send-email-ying.huang@intel.com> <1467135452-16688-2-git-send-email-ying.huang@intel.com> MIME-Version: 1.0 In-Reply-To: <1467135452-16688-2-git-send-email-ying.huang@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/06/29 16:26:39, Serialize by Router on LGEKRMHUB07/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/06/29 16:26:39, Serialize complete at 2016/06/29 16:26:39 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2016 at 10:36:30AM -0700, Huang, Ying wrote: > From: Huang Ying > > The definition of return value of madvise_free_huge_pmd is not clear > before. According to the suggestion of Minchan Kim, change the type of > return value to bool and return true if we do MADV_FREE successfully on > entire pmd page, otherwise, return false. Comments are added too. > > Cc: Minchan Kim > Signed-off-by: "Huang, Ying" Acked-by: Minchan Kim