* [PATCH] power: qcom-smbb: add extcon dependency
@ 2016-06-29 14:30 Arnd Bergmann
2016-06-29 14:38 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-06-29 14:30 UTC (permalink / raw)
To: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse
Cc: Arnd Bergmann, Courtney Cavin, linux-pm, linux-kernel
Building the smbb driver without extcon results in a link failure:
drivers/power/built-in.o: In function `smbb_usb_valid_handler':
:(.text+0x3190): undefined reference to `extcon_set_cable_state_'
drivers/power/built-in.o: In function `smbb_charger_probe':
:(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
:(.text+0x3898): undefined reference to `devm_extcon_dev_register'
This adds a Kconfig dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
---
drivers/power/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 0f11a0f4c369..acd4a1524a1e 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB
tristate "Qualcomm Switch-Mode Battery Charger and Boost"
depends on MFD_SPMI_PMIC || COMPILE_TEST
depends on OF
+ depends on EXTCON
help
Say Y to include support for the Switch-Mode Battery Charger and
Boost (SMBB) hardware found in Qualcomm PM8941 PMICs. The charger
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] power: qcom-smbb: add extcon dependency
2016-06-29 14:30 [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann
@ 2016-06-29 14:38 ` Sebastian Reichel
2016-06-29 18:10 ` Stephen Boyd
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2016-06-29 14:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Dmitry Eremin-Solenikov, David Woodhouse, Courtney Cavin,
linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
Hi,
On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> Building the smbb driver without extcon results in a link failure:
>
> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> drivers/power/built-in.o: In function `smbb_charger_probe':
> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
>
> This adds a Kconfig dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> ---
> drivers/power/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 0f11a0f4c369..acd4a1524a1e 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -394,6 +394,7 @@ config CHARGER_QCOM_SMBB
> tristate "Qualcomm Switch-Mode Battery Charger and Boost"
> depends on MFD_SPMI_PMIC || COMPILE_TEST
> depends on OF
> + depends on EXTCON
> help
> Say Y to include support for the Switch-Mode Battery Charger and
> Boost (SMBB) hardware found in Qualcomm PM8941 PMICs. The charger
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: qcom-smbb: add extcon dependency
2016-06-29 14:38 ` Sebastian Reichel
@ 2016-06-29 18:10 ` Stephen Boyd
2016-06-29 21:09 ` Sebastian Reichel
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2016-06-29 18:10 UTC (permalink / raw)
To: Sebastian Reichel, Arnd Bergmann
Cc: Dmitry Eremin-Solenikov, David Woodhouse, Courtney Cavin,
linux-pm, linux-kernel
On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
>> Building the smbb driver without extcon results in a link failure:
>>
>> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
>> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
>> drivers/power/built-in.o: In function `smbb_charger_probe':
>> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
>> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
>>
>> This adds a Kconfig dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
extcon use was only recently introduced so this should be
Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
detection")
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: qcom-smbb: add extcon dependency
2016-06-29 18:10 ` Stephen Boyd
@ 2016-06-29 21:09 ` Sebastian Reichel
2016-06-29 21:16 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2016-06-29 21:09 UTC (permalink / raw)
To: Stephen Boyd
Cc: Arnd Bergmann, Dmitry Eremin-Solenikov, David Woodhouse,
Courtney Cavin, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
Hi,
On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> >> Building the smbb driver without extcon results in a link failure:
> >>
> >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> >> drivers/power/built-in.o: In function `smbb_charger_probe':
> >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> >>
> >> This adds a Kconfig dependency.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
>
> extcon use was only recently introduced so this should be
>
> Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> detection")
Right, I didn't notice the Fixes line is wrong. Since I will have to
rebase now, I will just squash this into 0b7fe26ae602.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: qcom-smbb: add extcon dependency
2016-06-29 21:09 ` Sebastian Reichel
@ 2016-06-29 21:16 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-06-29 21:16 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Stephen Boyd, Dmitry Eremin-Solenikov, David Woodhouse,
Courtney Cavin, linux-pm, linux-kernel
On Wednesday, June 29, 2016 11:09:58 PM CEST Sebastian Reichel wrote:
> On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> > On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> > >> Building the smbb driver without extcon results in a link failure:
> > >>
> > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> > >> drivers/power/built-in.o: In function `smbb_charger_probe':
> > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> > >>
> > >> This adds a Kconfig dependency.
> > >>
> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> >
> > extcon use was only recently introduced so this should be
> >
> > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> > detection")
>
> Right, I didn't notice the Fixes line is wrong. Since I will have to
> rebase now, I will just squash this into 0b7fe26ae602.
Ok, thanks and sorry for the mixup, I must have pasted the wrong line.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-29 21:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29 14:30 [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann
2016-06-29 14:38 ` Sebastian Reichel
2016-06-29 18:10 ` Stephen Boyd
2016-06-29 21:09 ` Sebastian Reichel
2016-06-29 21:16 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox