From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbcF2QHY (ORCPT ); Wed, 29 Jun 2016 12:07:24 -0400 Received: from mail.kernel.org ([198.145.29.136]:35996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223AbcF2QHV (ORCPT ); Wed, 29 Jun 2016 12:07:21 -0400 Date: Wed, 29 Jun 2016 13:07:14 -0300 From: Arnaldo Carvalho de Melo To: Nilay Vaish Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 1/5] perf test: Add -F/--dont-fork option Message-ID: <20160629160714.GB5324@kernel.org> References: <1467113345-12669-1-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jun 29, 2016 at 11:04:01AM -0500, Nilay Vaish escreveu: > On 28 June 2016 at 06:29, Jiri Olsa wrote: > > Adding -F/--dont-fork option to bypass forking > > for each test. It's useful for debugging test. > > > > Link: http://lkml.kernel.org/n/tip-yq9gy0fcr8nl70986gwnl3dh@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/Documentation/perf-test.txt | 4 +++ > > tools/perf/tests/builtin-test.c | 55 ++++++++++++++++++++-------------- > > 2 files changed, 37 insertions(+), 22 deletions(-) > > > > This patch seems fine to me. In these cases, please state that more formally, i.e. please read Documentation/SubmittingPatches, specially this section: 12) When to use Acked-by: and: 13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: - Arnaldo