Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix

Michal Hocko
2016-06-30T08:20:42Z

On Wed 29-06-16 21:22:33, Oleg Nesterov wrote:
> On 06/29, Michal Hocko wrote:
> >
> > But it seems that further changes I am
> > planning in this area will benefit from stable task->mm in this path
>
> Oh, so I hope you will cleanup this later,
>
> > Just pull the task->mm !=
> > NULL check inside the function.
>
> OK, but this means it will always return false if the task is a zombie
> leader.
>
> I am not really arguing and this is not that bad, but this doesn't look
> nice and imo asks for cleanup.

I will keep that in mind and hopefully we can make this less obscure.
Who would like zombie leaders lurking around ;)
--
Michal Hocko
SUSE Labs