From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932643AbcF3QS0 (ORCPT ); Thu, 30 Jun 2016 12:18:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44863 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932434AbcF3QSY (ORCPT ); Thu, 30 Jun 2016 12:18:24 -0400 Date: Thu, 30 Jun 2016 18:18:16 +0200 From: Jiri Olsa To: Namhyung Kim Cc: David Ahern , Arnaldo Carvalho de Melo , lkml Subject: Re: [BUG] perf test 29 crashing Message-ID: <20160630161816.GA2939@krava> References: <20160628123410.GA1862@krava> <20160628165914.GJ27027@kernel.org> <6939ccab-dc51-27ab-69c0-9600f3a7ed6f@gmail.com> <20160629022006.GC1628@sejong> <20160630151016.GA4828@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160630151016.GA4828@krava> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 30 Jun 2016 16:18:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 05:10:16PM +0200, Jiri Olsa wrote: SNIP > > hate to be the only one with this.. now I need to dive in ;-) it was the setup in my .perfconfig: [call-graph] threshold=10 caused some of the callchains to disappear and screw the test, I think we should make that test using default values, like in attached patch however maybe we should think about disabling ~/.perfconfig overload for perf test at all I'll post patch below with my other stuff if there are no objection or another solution thanks, jirka --- diff --git a/tools/perf/tests/hists_cumulate.c b/tools/perf/tests/hists_cumulate.c index a9e3db3afac4..1208284a7338 100644 --- a/tools/perf/tests/hists_cumulate.c +++ b/tools/perf/tests/hists_cumulate.c @@ -666,6 +666,8 @@ static int test4(struct perf_evsel *evsel, struct machine *machine) perf_evsel__set_sample_bit(evsel, CALLCHAIN); setup_sorting(NULL); + + callchain_param = callchain_param_default; callchain_register_param(&callchain_param); err = add_hist_entries(hists, machine); diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h index a70f6b54eb92..13e75549c440 100644 --- a/tools/perf/util/callchain.h +++ b/tools/perf/util/callchain.h @@ -106,6 +106,7 @@ struct callchain_param { }; extern struct callchain_param callchain_param; +extern struct callchain_param callchain_param_default; struct callchain_list { u64 ip; diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index e08b9a092a23..5f44a21955cd 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -19,12 +19,19 @@ #include "callchain.h" #include "strlist.h" -struct callchain_param callchain_param = { - .mode = CHAIN_GRAPH_ABS, - .min_percent = 0.5, - .order = ORDER_CALLEE, - .key = CCKEY_FUNCTION, - .value = CCVAL_PERCENT, +#define CALLCHAIN_PARAM_DEFAULT \ + .mode = CHAIN_GRAPH_ABS, \ + .min_percent = 0.5, \ + .order = ORDER_CALLEE, \ + .key = CCKEY_FUNCTION, \ + .value = CCVAL_PERCENT, \ + +struct callchain_param callchain_param = { + CALLCHAIN_PARAM_DEFAULT +}; + +struct callchain_param callchain_param_default = { + CALLCHAIN_PARAM_DEFAULT }; /*