Re: [PATCH 00/10] Add clock support for Armada 37xx SoCs

Gregory CLEMENT
2016-07-04T20:29:40Z

Hi,

On ven., juin 10 2016, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:

> Hi,
>
> this series add clock support for the Armada 37xx SoCs.
>
> The design of the drivers is as close as possible as the hardware is,
> with some clocks made of several layers: muxing, divider and gating.
>
> The device tree binding was written in a way that even if we discover
> some change inside the clocks, the binding should not be
> affected. Especially, there are some holes in the clocks, but we
> should be able to add them seamless.
>
> I tried to follow the last update made in the clock framework, I hope
> theses drivers will comply the new guidelines.

I applied the first 4 patches on the mvebu branches, the first one on
mvebu/arm64 and the 3 other on mvebu/dt64. I did this in order to not
miss the arm-soc merge window.

The binding was acked by the dt maintainer and the review of the clk
maintainer was abut the internal of the driver. The only change I did
was fixing a typo in the address part of the name of the sb-periph-clk
node as pointed by Victor Gu. I will submit a second version soon
addressing these concerns.

Gregory

>
> Gregory CLEMENT (10):
> arm64: marvell: enable Armada 3700 clock drivers
> arm64: dts: marvell: Add xtal clock support for Armada 3700
> arm64: dts: marvell: add tbg clocks for Armada 37xx
> arm64: dts: marvell: add peripherals clocks for Armada 37xx
> dt-bindings: clock: add DT binding for the Xtal clock on Armada 3700
> clk: mvebu: Add the xtal clock for Armada 3700 SoC
> dt-bindings: clock: add DT binding for the TBG clocks on Armada 3700
> clk: mvebu Add the time base generator clocks for Armada 3700
> dt-bindings: clock: add DT binding for the peripheral clocks on Armada
> 3700
> clk: mvebu: Add the peripheral clock driver for Armada 3700
>
> .../bindings/clock/armada3700-periph-clock.txt | 70 ++++
> .../bindings/clock/armada3700-tbg-clock.txt | 27 ++
> .../bindings/clock/armada3700-xtal-clock.txt | 28 ++
> arch/arm64/Kconfig.platforms | 1 +
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 35 ++
> drivers/clk/mvebu/Kconfig | 3 +
> drivers/clk/mvebu/Makefile | 3 +
> drivers/clk/mvebu/armada-37xx-periph.c | 462 +++++++++++++++++++++
> drivers/clk/mvebu/armada-37xx-tbg.c | 172 ++++++++
> drivers/clk/mvebu/armada-37xx-xtal.c | 93 +++++
> 10 files changed, 894 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/armada3700-periph-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/armada3700-tbg-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/armada3700-xtal-clock.txt
> create mode 100644 drivers/clk/mvebu/armada-37xx-periph.c
> create mode 100644 drivers/clk/mvebu/armada-37xx-tbg.c
> create mode 100644 drivers/clk/mvebu/armada-37xx-xtal.c
>
> --
> 2.5.0
>

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.