From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbcGAAg7 (ORCPT ); Thu, 30 Jun 2016 20:36:59 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:35085 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbcGAAg5 (ORCPT ); Thu, 30 Jun 2016 20:36:57 -0400 X-Greylist: delayed 2101 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Jun 2016 20:36:57 EDT Date: Fri, 1 Jul 2016 01:53:48 +0200 From: Samuel Thibault To: Markus Mayer Cc: William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] staging: speakup: replace spk_strlwr() with strtolower() Message-ID: <20160630235348.GR4331@var.home> Mail-Followup-To: Samuel Thibault , Markus Mayer , William Hubbs , Chris Brannon , Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> <1467330612-26242-6-git-send-email-mmayer@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467330612-26242-6-git-send-email-mmayer@broadcom.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus Mayer, on Thu 30 Jun 2016 16:50:11 -0700, wrote: > After introducing generic strtolower(), spk_strlwr() is no longer > needed. > > Signed-off-by: Markus Mayer Acked-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 2 +- > drivers/staging/speakup/main.c | 2 +- > drivers/staging/speakup/speakup.h | 1 - > drivers/staging/speakup/varhandlers.c | 12 ------------ > 4 files changed, 2 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index 528cbdc..009c0d2 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -391,7 +391,7 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr, > if (new_synth_name[len - 1] == '\n') > len--; > new_synth_name[len] = '\0'; > - spk_strlwr(new_synth_name); > + strtolower(new_synth_name); > if ((synth != NULL) && (!strcmp(new_synth_name, synth->name))) { > pr_warn("%s already in use\n", new_synth_name); > } else if (synth_init(new_synth_name) != 0) { > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index 97ca4ec..3f3f254 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -2314,7 +2314,7 @@ static int __init speakup_init(void) > spk_initialize_msgs(); /* Initialize arrays for i18n. */ > spk_reset_default_chars(); > spk_reset_default_chartab(); > - spk_strlwr(synth_name); > + strtolower(synth_name); > spk_vars[0].u.n.high = vc->vc_cols; > for (var = spk_vars; var->var_id != MAXVARS; var++) > speakup_register_var(var); > diff --git a/drivers/staging/speakup/speakup.h b/drivers/staging/speakup/speakup.h > index df74c91..4725785 100644 > --- a/drivers/staging/speakup/speakup.h > +++ b/drivers/staging/speakup/speakup.h > @@ -50,7 +50,6 @@ void synth_insert_next_index(int sent_num); > void spk_reset_index_count(int sc); > void spk_get_index_count(int *linecount, int *sentcount); > int spk_set_key_info(const u_char *key_info, u_char *k_buffer); > -char *spk_strlwr(char *s); > char *spk_s2uchar(char *start, char *dest); > int speakup_kobj_init(void); > void speakup_kobj_exit(void); > diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c > index e1393d2..a1af222 100644 > --- a/drivers/staging/speakup/varhandlers.c > +++ b/drivers/staging/speakup/varhandlers.c > @@ -309,18 +309,6 @@ int spk_set_mask_bits(const char *input, const int which, const int how) > return 0; > } > > -char *spk_strlwr(char *s) > -{ > - char *p; > - > - if (!s) > - return NULL; > - > - for (p = s; *p; p++) > - *p = tolower(*p); > - return s; > -} > - > char *spk_s2uchar(char *start, char *dest) > { > int val; > -- > 2.7.4 > -- Samuel m'enfin, le 5 juillet, le mec vient visiter le labo... * D a marque d'une croix rouge le 5 juillet sur son agenda niarc niarc niarc cet homme va souffrir c'est donc le 5 juillet qu'il meurt d'un accident de la route écrasé par un truck muni d'un pare buffle -+- #ens-mim - repaire de terroristes -+-