From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbcGAIZ5 (ORCPT ); Fri, 1 Jul 2016 04:25:57 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:46964 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbcGAIZz (ORCPT ); Fri, 1 Jul 2016 04:25:55 -0400 Date: Fri, 1 Jul 2016 10:14:22 +0200 From: Peter Zijlstra To: David Howells Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Introduce rb_replace_node_rcu() Message-ID: <20160701081422.GN30921@twins.programming.kicks-ass.net> References: <20160701072238.GK30921@twins.programming.kicks-ass.net> <1412.1467356887@warthog.procyon.org.uk> <23000.1467360485@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23000.1467360485@warthog.procyon.org.uk> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2016 at 09:08:05AM +0100, David Howells wrote: > Peter Zijlstra wrote: > > > One little niggle below, but: > > How about the attached? I've updated that comment and rearranged > rb_replace_node_rcu(). Looks good, thanks!