From: Sean Young <sean@mess.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Joe Perches <joe@perches.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v2 15/15] [media] include: lirc: add LIRC_GET_LENGTH command
Date: Fri, 1 Jul 2016 10:27:59 +0100 [thread overview]
Message-ID: <20160701092759.GA8808@gofer.mess.org> (raw)
In-Reply-To: <1467360098-12539-16-git-send-email-andi.shyti@samsung.com>
On Fri, Jul 01, 2016 at 05:01:38PM +0900, Andi Shyti wrote:
> Added the get length command to allow userspace users to check on
> the data length.
So what does LIRC_GET_LENGTH do? If you want to add an ioctl, it
need justification, documenting in
Documentatoin/DocBook/media/v4l/lirc_device_interface.xml and there
should be at least one driver using it.
If you want to write a new driver which does IR transmit, it's best
to use the rc-core interface like the existing drivers and do
not use the lirc interface. Most of the other drivers which implement
IR transmit use rc-core too.
Sean
prev parent reply other threads:[~2016-07-01 9:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 8:01 [PATCH v2 00/15] lirc_dev fixes and beautification Andi Shyti
2016-07-01 8:01 ` [PATCH v2 01/15] [media] lirc_dev: place buffer allocation on separate function Andi Shyti
2016-07-01 8:01 ` [PATCH v2 02/15] [media] lirc_dev: allow bufferless driver registration Andi Shyti
2016-07-02 17:10 ` Sean Young
2016-07-01 8:01 ` [PATCH v2 03/15] [media] lirc_dev: remove unnecessary debug prints Andi Shyti
2016-07-01 8:01 ` [PATCH v2 04/15] [media] lirc_dev: replace printk with pr_* or dev_* Andi Shyti
2016-07-01 8:01 ` [PATCH v2 05/15] [media] lirc_dev: simplify goto paths Andi Shyti
2016-07-01 8:01 ` [PATCH v2 06/15] [media] lirc_dev: do not use goto to create loops Andi Shyti
2016-07-01 8:01 ` [PATCH v2 07/15] [media] lirc_dev: simplify if statement in lirc_add_to_buf Andi Shyti
2016-07-01 8:01 ` [PATCH v2 08/15] [media] lirc_dev: remove double if ... else statement Andi Shyti
2016-07-01 8:01 ` [PATCH v2 09/15] [media] lirc_dev: merge three if statements in only one Andi Shyti
2016-07-01 8:01 ` [PATCH v2 10/15] [media] lirc_dev: remove CONFIG_COMPAT precompiler check Andi Shyti
2016-07-04 11:39 ` Hans Verkuil
2016-07-01 8:01 ` [PATCH v2 11/15] [media] lirc_dev: fix variable constant comparisons Andi Shyti
2016-07-01 8:01 ` [PATCH v2 12/15] [media] lirc_dev: fix error return value Andi Shyti
2016-07-04 11:42 ` Hans Verkuil
2016-07-01 8:01 ` [PATCH v2 13/15] [media] lirc_dev: extremely trivial comment style fix Andi Shyti
2016-07-01 8:01 ` [PATCH v2 14/15] [media] lirc_dev: fix potential segfault Andi Shyti
2016-07-01 8:01 ` [PATCH v2 15/15] [media] include: lirc: add LIRC_GET_LENGTH command Andi Shyti
2016-07-01 9:27 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701092759.GA8808@gofer.mess.org \
--to=sean@mess.org \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox