From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: pi3orama <pi3orama@163.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org, Zefan Li <lizefan@huawei.com>
Subject: Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel
Date: Fri, 1 Jul 2016 11:43:01 -0300 [thread overview]
Message-ID: <20160701144301.GB2512@redhat.com> (raw)
In-Reply-To: <7B5601F4-1468-4BDB-85A0-E96396AF23BD@163.com>
Em Fri, Jul 01, 2016 at 10:27:35PM +0800, pi3orama escreveu:
> > 在 2016年7月1日，下午9:40，Arnaldo Carvalho de Melo <acme@kernel.org> 写道：
> > I.e. perhaps evsel->overwrite is completely unnecessary and places
> > checking for it should instead check for evsel->attr.backward, no?
> If we remove evsel->overwrite, what should we set in parser? Make it
> directly setting attr?
yeah, is that possible? Trying... And then overwrite is how we chose to
expose this to the user, in the event syntax, but internally that means
using the backwards_ring buffer, right?
So this simplifies the code, removing information that was being
duplicated in evsel->overwrite and evsel->attr.write_backward.
- Arnaldo
next prev parent reply other threads:[~2016-07-01 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 2:23 [PATCH v12 0/8] perf tools: Support overwritable ring buffer Wang Nan
2016-07-01 2:23 ` [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel Wang Nan
2016-07-01 13:40 ` Arnaldo Carvalho de Melo
2016-07-01 14:27 ` pi3orama
2016-07-01 14:43 ` Arnaldo Carvalho de Melo [this message]
2016-07-01 2:23 ` [PATCH v12 2/8] perf evlist: Introduce aux evlist Wang Nan
2016-07-01 2:23 ` [PATCH v12 3/8] perf tests: Add testcase for auxiliary evlist Wang Nan
2016-07-01 2:23 ` [PATCH v12 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Wang Nan
2016-07-01 2:23 ` [PATCH v12 5/8] perf record: Read from overwritable ring buffer Wang Nan
2016-07-01 2:23 ` [PATCH v12 6/8] perf tools: Enable overwrite settings Wang Nan
2016-07-01 2:23 ` [PATCH v12 7/8] perf tools: Don't warn about out of order event if write_backward is used Wang Nan
2016-07-01 2:23 ` [PATCH v12 8/8] perf tools: Add --tail-synthesize option Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701144301.GB2512@redhat.com \
--to=acme@redhat.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox