From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932218AbcGAOnH (ORCPT ); Fri, 1 Jul 2016 10:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41741 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104AbcGAOnF (ORCPT ); Fri, 1 Jul 2016 10:43:05 -0400 Date: Fri, 1 Jul 2016 11:43:01 -0300 From: Arnaldo Carvalho de Melo To: pi3orama Cc: Arnaldo Carvalho de Melo , Wang Nan , Jiri Olsa , linux-kernel@vger.kernel.org, Zefan Li Subject: Re: [PATCH v12 1/8] perf tests: Skip backward ring buffer on old kernel Message-ID: <20160701144301.GB2512@redhat.com> References: <1467339831-171169-1-git-send-email-wangnan0@huawei.com> <1467339831-171169-2-git-send-email-wangnan0@huawei.com> <20160701134042.GL5324@kernel.org> <7B5601F4-1468-4BDB-85A0-E96396AF23BD@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7B5601F4-1468-4BDB-85A0-E96396AF23BD@163.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 01 Jul 2016 14:43:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jul 01, 2016 at 10:27:35PM +0800, pi3orama escreveu: > > 在 2016年7月1日，下午9:40，Arnaldo Carvalho de Melo 写道： > > I.e. perhaps evsel->overwrite is completely unnecessary and places > > checking for it should instead check for evsel->attr.backward, no? > If we remove evsel->overwrite, what should we set in parser? Make it > directly setting attr? yeah, is that possible? Trying... And then overwrite is how we chose to expose this to the user, in the event syntax, but internally that means using the backwards_ring buffer, right? So this simplifies the code, removing information that was being duplicated in evsel->overwrite and evsel->attr.write_backward. - Arnaldo