From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbcGAVsl (ORCPT ); Fri, 1 Jul 2016 17:48:41 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36089 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbcGAVsk (ORCPT ); Fri, 1 Jul 2016 17:48:40 -0400 Date: Fri, 1 Jul 2016 14:40:23 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Andy Gross , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] soc: qcom: smem: Silence probe defer error Message-ID: <20160701214023.GM1190@tuxbot> References: <20160701211859.23471-1-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160701211859.23471-1-sboyd@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote: > If we fail to get the hwspinlock due to probe defer, we shouldn't > print an error message. Just be silent in this case. > This generally seems to result in a large pile of drivers ending up on the probe deferr list, so something we should try to avoid. But the patch itself looks good: Reviewed-by: Bjorn Andersson Regards, Bjorn > Cc: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- > drivers/soc/qcom/smem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index 2e1aa9f130f4..18ec52f2078a 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev) > > hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0); > if (hwlock_id < 0) { > - dev_err(&pdev->dev, "failed to retrieve hwlock\n"); > + if (hwlock_id != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to retrieve hwlock\n"); > return hwlock_id; > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >