From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbcGCF7W (ORCPT ); Sun, 3 Jul 2016 01:59:22 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33633 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985AbcGCF7U (ORCPT ); Sun, 3 Jul 2016 01:59:20 -0400 Date: Sun, 3 Jul 2016 14:59:24 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Joonsoo Kim , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 3/3] mm/page_owner: track page free call chain Message-ID: <20160703055924.GA513@swordfish> References: <20160702161656.14071-1-sergey.senozhatsky@gmail.com> <20160702161656.14071-4-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160702161656.14071-4-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/03/16 01:16), Sergey Senozhatsky wrote: [..] > +#ifdef CONFIG_PAGE_OWNER_TRACK_FREE > +void __page_owner_free_pages(struct page *page, unsigned int order) > +{ > + int i; > + depot_stack_handle_t handle; > + struct page_ext *page_ext = lookup_page_ext(page); > + > + if (unlikely(!page_ext)) > + return; > + > + handle = save_stack(0); > + page_ext->handles[PAGE_OWNER_HANDLE_FREE] = handle; > + __set_bit(PAGE_EXT_OWNER_FREE, &page_ext->flags); > + > + for (i = 1; i < (1 << order); i++) { > + struct page_ext *ext = lookup_page_ext(page + 1); > + > + if (unlikely(!ext)) > + continue; > + ext->handles[PAGE_OWNER_HANDLE_FREE] = handle; > + __set_bit(PAGE_EXT_OWNER_FREE, &ext->flags); > + } > +} I think this one is missing __clear_bit(PAGE_EXT_OWNER_ALLOC). --- mm/page_owner.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/page_owner.c b/mm/page_owner.c index 5a108d6..699922c 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -154,6 +154,7 @@ void __page_owner_free_pages(struct page *page, unsigned int order) handle = save_stack(0); page_ext->handles[PAGE_OWNER_HANDLE_FREE] = handle; __set_bit(PAGE_EXT_OWNER_FREE, &page_ext->flags); + __clear_bit(PAGE_EXT_OWNER_ALLOC, &page_ext->flags); for (i = 1; i < (1 << order); i++) { struct page_ext *ext = lookup_page_ext(page + 1); @@ -162,6 +163,7 @@ void __page_owner_free_pages(struct page *page, unsigned int order) continue; ext->handles[PAGE_OWNER_HANDLE_FREE] = handle; __set_bit(PAGE_EXT_OWNER_FREE, &ext->flags); + __clear_bit(PAGE_EXT_OWNER_ALLOC, &ext->flags); } } #else -- 2.9.0.rc1