From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366AbcGDAEf (ORCPT ); Sun, 3 Jul 2016 20:04:35 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:47478 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932249AbcGDAEe (ORCPT ); Sun, 3 Jul 2016 20:04:34 -0400 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Mon, 4 Jul 2016 09:05:16 +0900 From: Minchan Kim To: Ganesh Mahendran CC: , , , , , , Subject: Re: [PATCH 6/8] mm/zsmalloc: keep comments consistent with code Message-ID: <20160704000516.GE19044@bbox> References: <1467355266-9735-1-git-send-email-opensource.ganesh@gmail.com> <1467355266-9735-6-git-send-email-opensource.ganesh@gmail.com> MIME-Version: 1.0 In-Reply-To: <1467355266-9735-6-git-send-email-opensource.ganesh@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/07/04 09:04:30, Serialize by Router on LGEKRMHUB03/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/07/04 09:04:30, Serialize complete at 2016/07/04 09:04:30 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote: > some minor change of comments: > 1). update zs_malloc(),zs_create_pool() function header > 2). update "Usage of struct page fields" > > Signed-off-by: Ganesh Mahendran > --- > mm/zsmalloc.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 2690914..6fc631a 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -20,6 +20,7 @@ > * page->freelist(index): links together all component pages of a zspage > * For the huge page, this is always 0, so we use this field > * to store handle. > + * page->units: first object index in a subpage of zspage Hmm, I want to use offset instead of index.