From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932569AbcGDDcb (ORCPT ); Sun, 3 Jul 2016 23:32:31 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35221 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbcGDDc1 (ORCPT ); Sun, 3 Jul 2016 23:32:27 -0400 Date: Mon, 4 Jul 2016 11:32:21 +0800 From: Ganesh Mahendran To: Minchan Kim Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org, mingo@redhat.com Subject: Re: [PATCH 6/8] mm/zsmalloc: keep comments consistent with code Message-ID: <20160704033221.GD9895@leo-test> References: <1467355266-9735-1-git-send-email-opensource.ganesh@gmail.com> <1467355266-9735-6-git-send-email-opensource.ganesh@gmail.com> <20160704000516.GE19044@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160704000516.GE19044@bbox> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 04, 2016 at 09:05:16AM +0900, Minchan Kim wrote: > On Fri, Jul 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote: > > some minor change of comments: > > 1). update zs_malloc(),zs_create_pool() function header > > 2). update "Usage of struct page fields" > > > > Signed-off-by: Ganesh Mahendran > > --- > > mm/zsmalloc.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index 2690914..6fc631a 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -20,6 +20,7 @@ > > * page->freelist(index): links together all component pages of a zspage > > * For the huge page, this is always 0, so we use this field > > * to store handle. > > + * page->units: first object index in a subpage of zspage > > Hmm, I want to use offset instead of index. Yes, it should be offset here. I mixed it with obj index. :) Thanks