From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932708AbcGDJ2M (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jul 2016 05:28:12 -0400
Received: from foss.arm.com ([217.140.101.70]:46285 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753432AbcGDJ2I (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jul 2016 05:28:08 -0400
Date: Mon, 4 Jul 2016 10:28:28 +0100
From: Juri Lelli <juri.lelli@arm.com>
To: luca abeni <luca.abeni@unitn.it>
Cc: peterz@infradead.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org,
        mingo@redhat.com
Subject: Re: [PATCH v2] sched/deadline: remove useless param from
 setup_new_dl_entity
Message-ID: <20160704092828.GB9218@e106622-lin>
References: <1467227263-31349-1-git-send-email-juri.lelli@arm.com>
 <20160704110324.129bebb4@utopia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160704110324.129bebb4@utopia>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/07/16 11:03, Luca Abeni wrote:
> Hi Juri,
> 
> On Wed, 29 Jun 2016 20:07:43 +0100
> Juri Lelli <juri.lelli@arm.com> wrote:
> 
> > setup_new_dl_entity() takes two parameters, but it only actually uses
> > one of them, under a different name, to setup a new dl_entity, after:
> > 
> >  2f9f3fdc928 "sched/deadline: Remove dl_new from struct
> > sched_dl_entity"
> > 
> > as we currently do
> > 
> >  setup_new_dl_entity(&p->dl, &p->dl)
> > 
> > However, before Luca's change we were doing
> > 
> >  setup_new_dl_entity(dl_se, pi_se)
> > 
> > in update_dl_entity() for a dl_se->new entity: we were using pi_se's
> > parameters (the potential PI donor) for setting up a new entity.
> > 
> > Restore this behaviour (as we want to correctly initialize parameters
> > of a boosted task that enters DEADLINE) by removing the useless second
> > parameter of setup_new_dl_entity() and retrieving the top waiter
> > directly from inside that function.
> I did not have time to test this patch yet, but it still looks good to
> me.
> 

Thanks for reviewing it.

Best,

- Juri