From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932453AbcGDCDg (ORCPT <rfc822;w@1wt.eu>);
	Sun, 3 Jul 2016 22:03:36 -0400
Received: from mail.kernel.org ([198.145.29.136]:55294 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932236AbcGDCDf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 3 Jul 2016 22:03:35 -0400
Date: Mon, 4 Jul 2016 11:03:29 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [PATCH perf/core v13 02/15] perf probe: Show all cached probes
Message-Id: <20160704110329.16a776a8278115dc990b13c0@kernel.org>
In-Reply-To: <20160701135104.GM5324@kernel.org>
References: <146736018054.27797.14439910564760436056.stgit@devbox>
	<146736020674.27797.13488316780383460180.stgit@devbox>
	<20160701135104.GM5324@kernel.org>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 1 Jul 2016 10:51:04 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Fri, Jul 01, 2016 at 05:03:26PM +0900, Masami Hiramatsu escreveu:
> > From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> > 
> > perf probe --list shows all cached probes when --cache
> > is given. Each caches are shown with on which binary that
> > probed. e.g.
> >   -----
> >   # perf probe --cache vfs_read \$params
> 
> This one works:
> 
> # perf probe --cache vfs_read \$params
> Added new event:
>   probe:vfs_read       (on vfs_read with $params)
> 
> You can now use it in all perf tools, such as:
> 
> 	perf record -e probe:vfs_read -aR sleep 1
> 
> #
> 
> >   # perf probe --cache -x /lib64/libc-2.17.so getaddrinfo \$params
> 
> But this one doesn't and provides a funny message:
> 
> [root@jouet perf]# perf probe --cache -x /lib64/libc-2.23.so getaddrinfo \$params
> Failed to write event: Invalid argument
> Please upgrade your kernel to at least 3.14 to have access to feature $params
>   Error: Failed to add events.

Ah, OK, $params requires debuginfo. It this error message is not correct.
I'll send a fix soon.

Thanks!!


-- 
Masami Hiramatsu <mhiramat@kernel.org>