linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Thor Thayer <tthayer@opensource.altera.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular
Date: Mon, 4 Jul 2016 21:25:39 -0400	[thread overview]
Message-ID: <20160705012544.14143-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160705012544.14143-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/mfd/Kconfig:config MFD_ALTERA_A10SR
drivers/mfd/Kconfig:    bool "Altera Arria10 DevKit System Resource chip"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since builtin_driver() uses the same init level priority as
module_spi_driver() the init ordering remains unchanged with
this commit. [Note that there is no builtin_spi_driver macro,
so we open-code what it would be via builtin_driver().]

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Thor Thayer <tthayer@opensource.altera.com>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/mfd/altera-a10sr.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c
index c05aa4ff57fd..78c2fb7d7f33 100644
--- a/drivers/mfd/altera-a10sr.c
+++ b/drivers/mfd/altera-a10sr.c
@@ -1,4 +1,8 @@
 /*
+ * Altera Arria10 DevKit System Resource MFD Driver
+ *
+ * Author: Thor Thayer <tthayer@opensource.altera.com>
+ *
  * Copyright Intel Corporation (C) 2014-2016. All Rights Reserved
  *
  * This program is free software; you can redistribute it and/or modify it
@@ -20,7 +24,7 @@
 
 #include <linux/mfd/altera-a10sr.h>
 #include <linux/mfd/core.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/of.h>
 #include <linux/spi/spi.h>
 
@@ -152,7 +156,6 @@ static const struct of_device_id altr_a10sr_spi_of_match[] = {
 	{ .compatible = "altr,a10sr" },
 	{ },
 };
-MODULE_DEVICE_TABLE(of, altr_a10sr_spi_of_match);
 
 static struct spi_driver altr_a10sr_spi_driver = {
 	.probe = altr_a10sr_spi_probe,
@@ -161,9 +164,4 @@ static struct spi_driver altr_a10sr_spi_driver = {
 		.of_match_table = of_match_ptr(altr_a10sr_spi_of_match),
 	},
 };
-
-module_spi_driver(altr_a10sr_spi_driver);
-
-MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Thor Thayer <tthayer@opensource.altera.com>");
-MODULE_DESCRIPTION("Altera Arria10 DevKit System Resource MFD Driver");
+builtin_driver(altr_a10sr_spi_driver, spi_register_driver)
-- 
2.8.4

  reply	other threads:[~2016-07-05  1:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  1:25 [PATCH 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-07-05  1:25 ` Paul Gortmaker [this message]
2016-08-05 12:57   ` [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular Lee Jones
2016-08-23 20:56     ` Paul Gortmaker
2016-08-31 11:43       ` Lee Jones
2016-07-05  1:25 ` [PATCH 2/6] mfd: as3722: Make " Paul Gortmaker
2016-07-05  5:48   ` Laxman Dewangan
2016-07-06 16:45     ` Paul Gortmaker
2016-08-05 12:56       ` Lee Jones
2016-08-05 13:50         ` Paul Gortmaker
2016-08-08  9:14           ` Lee Jones
2016-08-08 14:01             ` Paul Gortmaker
2016-07-05  1:25 ` [PATCH 3/6] mfd: intel_msic: " Paul Gortmaker
2016-07-05 10:08   ` Mika Westerberg
2016-07-06 16:38     ` Paul Gortmaker
2016-07-07  8:11       ` Mika Westerberg
2016-07-07 10:26         ` Andy Shevchenko
2016-07-07 10:33           ` Mika Westerberg
2016-08-05 12:57   ` Lee Jones
2016-07-05  1:25 ` [PATCH 4/6] mfd: smsc-ece1099: " Paul Gortmaker
2016-08-05 12:57   ` Lee Jones
2016-07-05  1:25 ` [PATCH 5/6] mfd: sun6i-prcm: " Paul Gortmaker
2016-07-05  6:24   ` Maxime Ripard
2016-08-05 12:57   ` Lee Jones
2016-07-05  1:25 ` [PATCH 6/6] mfd: twl-core: " Paul Gortmaker
2016-08-05 12:58   ` Lee Jones
  -- strict thread matches above, loose matches on Subject: below --
2016-09-12 14:40 [PATCH v2 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-09-12 14:40 ` [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular Paul Gortmaker
2016-09-13  8:52   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705012544.14143-2-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tthayer@opensource.altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).