From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Sourav Poddar <sourav.poddar@ti.com>
Subject: [PATCH 4/6] mfd: smsc-ece1099: Make it explicitly non-modular
Date: Mon, 4 Jul 2016 21:25:42 -0400 [thread overview]
Message-ID: <20160705012544.14143-5-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160705012544.14143-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/mfd/Kconfig:config MFD_SMSC
drivers/mfd/Kconfig: bool "SMSC ECE1099 series chips"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.
We replace module.h with init.h and delete an unused moduleparam.h
include.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Sourav Poddar <sourav.poddar@ti.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/mfd/smsc-ece1099.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
index cd18c09827ef..1f40baf1234e 100644
--- a/drivers/mfd/smsc-ece1099.c
+++ b/drivers/mfd/smsc-ece1099.c
@@ -11,8 +11,7 @@
*
*/
-#include <linux/module.h>
-#include <linux/moduleparam.h>
+#include <linux/init.h>
#include <linux/slab.h>
#include <linux/i2c.h>
#include <linux/gpio.h>
@@ -81,7 +80,6 @@ static const struct i2c_device_id smsc_i2c_id[] = {
{ "smscece1099", 0},
{},
};
-MODULE_DEVICE_TABLE(i2c, smsc_i2c_id);
static struct i2c_driver smsc_i2c_driver = {
.driver = {
@@ -90,9 +88,4 @@ static struct i2c_driver smsc_i2c_driver = {
.probe = smsc_i2c_probe,
.id_table = smsc_i2c_id,
};
-
-module_i2c_driver(smsc_i2c_driver);
-
-MODULE_AUTHOR("Sourav Poddar <sourav.poddar@ti.com>");
-MODULE_DESCRIPTION("SMSC chip multi-function driver");
-MODULE_LICENSE("GPL v2");
+builtin_i2c_driver(smsc_i2c_driver);
--
2.8.4
next prev parent reply other threads:[~2016-07-05 1:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 1:25 [PATCH 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-07-05 1:25 ` [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular Paul Gortmaker
2016-08-05 12:57 ` Lee Jones
2016-08-23 20:56 ` Paul Gortmaker
2016-08-31 11:43 ` Lee Jones
2016-07-05 1:25 ` [PATCH 2/6] mfd: as3722: Make " Paul Gortmaker
2016-07-05 5:48 ` Laxman Dewangan
2016-07-06 16:45 ` Paul Gortmaker
2016-08-05 12:56 ` Lee Jones
2016-08-05 13:50 ` Paul Gortmaker
2016-08-08 9:14 ` Lee Jones
2016-08-08 14:01 ` Paul Gortmaker
2016-07-05 1:25 ` [PATCH 3/6] mfd: intel_msic: " Paul Gortmaker
2016-07-05 10:08 ` Mika Westerberg
2016-07-06 16:38 ` Paul Gortmaker
2016-07-07 8:11 ` Mika Westerberg
2016-07-07 10:26 ` Andy Shevchenko
2016-07-07 10:33 ` Mika Westerberg
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` Paul Gortmaker [this message]
2016-08-05 12:57 ` [PATCH 4/6] mfd: smsc-ece1099: " Lee Jones
2016-07-05 1:25 ` [PATCH 5/6] mfd: sun6i-prcm: " Paul Gortmaker
2016-07-05 6:24 ` Maxime Ripard
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 6/6] mfd: twl-core: " Paul Gortmaker
2016-08-05 12:58 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2016-09-12 14:40 [PATCH v2 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-09-12 14:40 ` [PATCH 4/6] mfd: smsc-ece1099: Make it explicitly non-modular Paul Gortmaker
2016-09-13 8:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705012544.14143-5-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).