From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754566AbcGEGWN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jul 2016 02:22:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57741 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751492AbcGEGUh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jul 2016 02:20:37 -0400
Date: Tue, 5 Jul 2016 08:20:32 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, He Kuang <hekuang@huawei.com>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 3/4] perf tools: Add initialized arg into
 unwind__prepare_access
Message-ID: <20160705062032.GA15745@krava>
References: <1467634583-29147-1-git-send-email-jolsa@kernel.org>
 <1467634583-29147-4-git-send-email-jolsa@kernel.org>
 <20160704192511.GX5324@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160704192511.GX5324@kernel.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 05 Jul 2016 06:20:36 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 04, 2016 at 04:25:11PM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> >  }
> > @@ -67,7 +69,8 @@ unwind__get_entries(unwind_entry_cb_t cb __maybe_unused,
> >  }
> >  
> >  static inline int unwind__prepare_access(struct thread *thread __maybe_unused,
> > -					 struct map *map __maybe_unused)
> > +					 struct map *map __maybe_unused,
> > +					 bool *initialized __maybe_unused);
> >  {
> >  	return 0;
> >  }
> 
> That extra ; breaks the build on centos5 (i.e. on an arch where the
> above code gets compiled:
> 
>   CC       /tmp/build/perf/bench/sched-pipe.o
> In file included from util/machine.c:14:
> util/unwind.h:74: error: expected identifier or '(' before '{' token
>   MKDIR    /tmp/build/perf/tests/
>   CC       /tmp/build/perf/tests/parse-events.o
> mv: cannot stat `/tmp/build/perf/util/.machine.o.tmp': No such file or directory
> make[3]: *** [/tmp/build/perf/util/machine.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
>   MKDIR    /tmp/build/perf/tests/
>   CC       /tmp/build/perf/tests/dso-data.o
> make[2]: *** [util] Error 2
> make[1]: *** [/tmp/build/perf/libperf-in.o] Error 2
> make[1]: *** Waiting for unfinished jobs....
>   MKDIR    /tmp/build/perf/tests/
> 
> 
> Fixing it.

oops, thanks

jirka