From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751253AbcGEIfo (ORCPT ); Tue, 5 Jul 2016 04:35:44 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60886 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbcGEIfe (ORCPT ); Tue, 5 Jul 2016 04:35:34 -0400 Date: Tue, 5 Jul 2016 10:35:26 +0200 From: Peter Zijlstra To: Mark Rutland Cc: linux-kernel@vger.kernel.org, Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Will Deacon Subject: Re: [PATCH] perf: fix pmu::filter_match for SW-led groups Message-ID: <20160705083526.GY30921@twins.programming.kicks-ass.net> References: <1465917041-15339-1-git-send-email-mark.rutland@arm.com> <20160702164025.GU30921@twins.programming.kicks-ass.net> <20160704180534.GD9048@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160704180534.GD9048@leverpostej> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 04, 2016 at 07:05:35PM +0100, Mark Rutland wrote: > On Sat, Jul 02, 2016 at 06:40:25PM +0200, Peter Zijlstra wrote: > > One of the ways I was looking at getting that done is a virtual runtime > > scheduler (just like cfs). The tricky point is merging two virtual > > runtime trees. But I think that should be doable if we sort the trees on > > lag. > > > > In any case, the relevance to your question is that once we have a tree, > > we can play games with order; that is, if we first order on PMU-id and > > only second on lag, we get whole subtree clusters specific for a PMU. > > Hmm... I'm not sure how that helps in this case. Wouldn't we still need > to walk the sibling list to get the HW PMU-id in the case of a SW group > leader? Since there is a hardware even in the group, it must be part of the hardware pmu list/tree and would thus end up classified (and sorted) by that (hardware) PMU-id. > For the heterogeenous case we'd need a different sort order per-cpu > (well, per microarchitecture), which sounds like we're going to have to > fully sort the events every time they move between CPUs. :/ Confused, I thought that for the HG case you had multiple events, one for each PMU. If we classify these events differently we'd simply use a different subtree depending on which CPU the task lands. Currently we've munged the two PMUs together, because, well, that's the only way. > I also had another though about solving the SW-led group case: if the > leader had a reference to the group's HW PMU (of which there should only > be one), we can filter on that alone, and can also use that in > group_sched_in rather than the ctx->pmu, avoiding the issue that > ctx->pmu is not the same as the group's HW PMU. > > I'll have a play with that approach in the mean time. Right, adds one more pointer to the struct event, but that thing is massive already.