From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754435AbcGEIw2 (ORCPT ); Tue, 5 Jul 2016 04:52:28 -0400 Received: from foss.arm.com ([217.140.101.70]:51450 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754218AbcGEIw1 (ORCPT ); Tue, 5 Jul 2016 04:52:27 -0400 Date: Tue, 5 Jul 2016 09:52:47 +0100 From: Juri Lelli To: Wanpeng Li Cc: Peter Zijlstra , Steven Rostedt , "linux-kernel@vger.kernel.org" , Ingo Molnar , Luca Abeni Subject: Re: [PATCH v2] sched/deadline: remove useless param from setup_new_dl_entity Message-ID: <20160705085247.GF17689@e106622-lin> References: <1467227263-31349-1-git-send-email-juri.lelli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/16 15:37, Wanpeng Li wrote: > 2016-06-30 3:07 GMT+08:00 Juri Lelli : > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them, under a different name, to setup a new dl_entity, after: > > > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > > > as we currently do > > > > setup_new_dl_entity(&p->dl, &p->dl) > > > > However, before Luca's change we were doing > > > > setup_new_dl_entity(dl_se, pi_se) > > > > in update_dl_entity() for a dl_se->new entity: we were using pi_se's > > parameters (the potential PI donor) for setting up a new entity. > > > > Restore this behaviour (as we want to correctly initialize parameters of > > a boosted task that enters DEADLINE) by removing the useless second > > parameter of setup_new_dl_entity() and retrieving the top waiter > > directly from inside that function. > > > > Cc: Ingo Molnar > > Cc: Peter Zijlstra > > Cc: Steven Rostedt > > Cc: Luca Abeni > > Signed-off-by: Juri Lelli > > > > Reviewed-by: Wanpeng Li > Thanks! - Juri