From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754376AbcGEJZZ (ORCPT ); Tue, 5 Jul 2016 05:25:25 -0400 Received: from down.free-electrons.com ([37.187.137.238]:39689 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751150AbcGEJZW (ORCPT ); Tue, 5 Jul 2016 05:25:22 -0400 Date: Tue, 5 Jul 2016 11:25:10 +0200 From: "maxime.ripard@free-electrons.com" To: Icenowy Zheng Cc: Michael Haas , "wens@csie.org" , "sre@kernel.org" , "dbaryshkov@gmail.com" , "dwmw2@infradead.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-sunxi@googlegroups.com" Subject: Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver Message-ID: <20160705092510.GL7643@lukather> References: <20160701092926.32005-1-icenowy@aosc.xyz> <20160701092926.32005-2-icenowy@aosc.xyz> <577B44FD.6040404@mailbox.org> <4101467707611@web7h.yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lZZ4ablUVnt2XgAh" Content-Disposition: inline In-Reply-To: <4101467707611@web7h.yandex.ru> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lZZ4ablUVnt2XgAh Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2016 at 04:33:31PM +0800, Icenowy Zheng wrote: >=20 >=20 > 05.07.2016, 13:26, "Michael Haas" : > > Hi, > > > > nice work! Is this in any way related to Bruno Pr=E9monts driver for the > > axp20x? > > > > I've got a reworked version of that lying around, but it's not quite > > ready for submission. Do you know what pieces are missing in your driver > > for axp20x support - as opposed to axp22x, which is already working? >=20 > Therotically, it can run on axp20x. However, I have currently no > test device. (Still waiting for my C.H.I.P.) So I can only promise > it to run on axp22x. Still, it looks like you just took Bruno's driver, stripped out the axp20x parts and added the one to deal with axp22x. This makes the driver look weird, by being called axp20x, without actually supporting those PMICs, but having some axp22x variables right in the middle. And that's awfully inconsistent. I'd rather have you add the AXP20x driver directly, and then add the needed stuff for the AXP22x. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --lZZ4ablUVnt2XgAh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXe3z2AAoJEBx+YmzsjxAgArUP/Rkq3WX0vQ0EbAct4GueGkug t+x4elgqXHafCLpNN5ZVJBappYw92qcC473xXqIM/NR7h0TLUnzxYGtjFY0P/Ny3 yCRwu3nkhSHqia+PMciDfXs6ihl0hywIOjbk/BEooL6KtW2Zp3bG04aczH3kttpv dnhEV819jXrYCXD2Do9bATpagrQ9gDU8S1odwdRfwTjDHRVUaEm8Zqa3mybv6rxE pfqXnNDEi9kw3vr0RQSekG/lonwaD2r6CXQ97oOYaalMHwEYZ9kh1vlyhBgCxkDZ FCb6rKXMnc2psi0SfsA0LubHCZ4wcIuJqV3sZGtQrR2cndLKq4Bh681hEWsJjwPv 8U5K5CVlyurV9L6eUeMmsn5rAnidq15UBdRF6bpymZYJQ51ed8EUlPjd0cD7ufYu qorxJsAPSUTuX3rWzlsNLPlebIHH9do+u3W0J0hYRin3bCoQ5DkKzQDFE0sBqcsO 0s3w878IRgH8nS5FsWghZBd2EP3aAsIRq9IWvG9IZxGQkI23/Y+dSC8CIGocY8Z1 vqnN2LEB3i6haCs1JY2JhpPY0XQ0ugA9kkERnPxfUxwZubkPvaEPFm10OmEitEwK QAxaD6vwWi0hrGnWRPofweNDCa7uMjIpuNMYY/I3R7ozRv8nYbnAYp/9YlrKGmk1 mX18o9cSjgmYZ0cs+cGZ =v/Am -----END PGP SIGNATURE----- --lZZ4ablUVnt2XgAh--