From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932851AbcGEKI2 (ORCPT ); Tue, 5 Jul 2016 06:08:28 -0400 Received: from mga14.intel.com ([192.55.52.115]:13421 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbcGEKIZ (ORCPT ); Tue, 5 Jul 2016 06:08:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,579,1459839600"; d="scan'208";a="840846485" Date: Tue, 5 Jul 2016 13:08:21 +0300 From: Mika Westerberg To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Lee Jones Subject: Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular Message-ID: <20160705100821.GK23527@lahna.fi.intel.com> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-4-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160705012544.14143-4-paul.gortmaker@windriver.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 04, 2016 at 09:25:41PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_INTEL_MSIC > drivers/mfd/Kconfig: bool "Intel MSIC" I would prefer if it could be turned to tristate instead. I don't see any reasons why it should only be builtin.