From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764AbcGEKzb (ORCPT ); Tue, 5 Jul 2016 06:55:31 -0400 Received: from outbound-smtp07.blacknight.com ([46.22.139.12]:50547 "EHLO outbound-smtp07.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbcGEKza (ORCPT ); Tue, 5 Jul 2016 06:55:30 -0400 Date: Tue, 5 Jul 2016 11:55:26 +0100 From: Mel Gorman To: Hillf Danton Cc: Michal Hocko , linux-kernel , linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Message-ID: <20160705105526.GK11498@techsingularity.net> References: <00f601d1d691$d790ad40$86b207c0$@alibaba-inc.com> <00fa01d1d694$42f6a7e0$c8e3f7a0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <00fa01d1d694$42f6a7e0$c8e3f7a0$@alibaba-inc.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 05, 2016 at 04:07:23PM +0800, Hillf Danton wrote: > > + /* > > + * Would the allocation succeed if we reclaimed the whole > > + * available? This is approximate because there is no > > + * accurate count of reclaimable pages per zone. > > + */ > > + for (zid = 0; zid <= zone_idx(zone); zid++) { > > + struct zone *check_zone = ¤t_pgdat->node_zones[zid]; > > + unsigned long estimate; > > + > > + estimate = min(check_zone->managed_pages, available); > > + if (__zone_watermark_ok(check_zone, order, > > + min_wmark_pages(check_zone), ac_classzone_idx(ac), > > + alloc_flags, available)) { > > + } > Stray indent? > Last minute rebase-related damage. I'll fix it. -- Mel Gorman SUSE Labs