From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755021AbcGENp0 (ORCPT ); Tue, 5 Jul 2016 09:45:26 -0400 Received: from pmta2.delivery5.ore.mailhop.org ([54.186.218.12]:18180 "EHLO pmta2.delivery5.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbcGENpZ (ORCPT ); Tue, 5 Jul 2016 09:45:25 -0400 X-MHO-User: d33acf34-42b6-11e6-8929-8ded99d5e9d7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 74.99.78.160 X-Mail-Handler: DuoCircle Outbound SMTP X-DKIM: OpenDKIM Filter v2.6.8 io A5B2480025 Date: Tue, 5 Jul 2016 13:45:20 +0000 From: Jason Cooper To: Qiang Zhao Cc: "oss@buserror.net" , "tglx@linutronix.de" , "marc.zyngier@arm.com" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Xiaobo Xie Subject: Re: [PATCH 2/2] qe/ic: refactor qe_ic to simplify Message-ID: <20160705134520.GC3348@io.lakedaemon.net> References: <1467683219-29326-1-git-send-email-qiang.zhao@nxp.com> <1467683219-29326-2-git-send-email-qiang.zhao@nxp.com> <20160705035100.GB3348@io.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Morning! On Tue, Jul 05, 2016 at 07:38:49AM +0000, Qiang Zhao wrote: > On 07/05/2016 11:51 AM, Jason Cooper wrote: > > On Tue, Jul 05, 2016 at 09:46:59AM +0800, Zhao Qiang wrote: ... > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > drivers/irqchip/qe_ic.c | 83 +++++++++++++++++++++++++------------------ > > --- > > > include/soc/fsl/qe/qe_ic.h | 7 ---- > > > 2 files changed, 45 insertions(+), 45 deletions(-) > > > > > > diff --git a/drivers/irqchip/qe_ic.c b/drivers/irqchip/qe_ic.c index > > > f7f9a81..46652c0 100644 > > > --- a/drivers/irqchip/qe_ic.c > > > +++ b/drivers/irqchip/qe_ic.c ... > > > - printk(KERN_DEBUG "Registering qe_ic with sysfs...\n"); > > > + ret = qe_ic_init(0); > > > > Sorry, build machine is down atm. How was qe_ic_init() called previously? Is > > that removed? > > Sorry, I don't understand, could you please explain? -ENOSLEEP when I wrote that. :) *My* build machine, with my copies of the kernel tree was down, so I had no easy way to dig into the source. And .... > > > -static int __init qeic_of_init(void) > > > -{ > > > - struct device_node *np; > > > - > > > - np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); > > > - if (np) { > > > - qe_ic_init(np, 0, qe_ic_cascade_low_mpic, > > > - qe_ic_cascade_high_mpic); > > > - of_node_put(np); > > > - } > > > return 0; > > > } > > > > > > -subsys_initcall(qeic_of_init); this block is what I missed last night. :-/ Sorry for the noise. thx, Jason.