From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755282AbcGEODI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jul 2016 10:03:08 -0400
Received: from mail5.windriver.com ([192.103.53.11]:57231 "EHLO mail5.wrs.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755258AbcGEODD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jul 2016 10:03:03 -0400
Date: Tue, 5 Jul 2016 10:02:18 -0400
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Alexandre TORGUE <alexandre.torgue@st.com>
CC: Linus Walleij <linus.walleij@linaro.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Patrice Chotard <patrice.chotard@st.com>,
        Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/3] pinctrl: Add STM32F746 MCU support
Message-ID: <20160705140218.GD26134@windriver.com>
References: <1467726017-20041-1-git-send-email-alexandre.torgue@st.com>
 <1467726017-20041-3-git-send-email-alexandre.torgue@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1467726017-20041-3-git-send-email-alexandre.torgue@st.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[[PATCH 2/3] pinctrl: Add STM32F746 MCU support] On 05/07/2016 (Tue 15:40) Alexandre TORGUE wrote:

> From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> 
> This patch which adds STM32F746 pinctrl and GPIO support, relies on the
> generic STM32 pinctrl driver.
> 
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
> 
> diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig
> index 0f28841..4c40dae 100644
> --- a/drivers/pinctrl/stm32/Kconfig
> +++ b/drivers/pinctrl/stm32/Kconfig
> @@ -13,4 +13,10 @@ config PINCTRL_STM32F429
>  	default MACH_STM32F429
>  	select PINCTRL_STM32
>  
> +config PINCTRL_STM32F746
> +	bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746
        ^^^^

> +	depends on OF
> +	default MACH_STM32F746
> +	select PINCTRL_STM32
> +
> +	),
> +};
> +

[...]

> +static const struct of_device_id stm32f746_pctrl_match[] = {
> +	{
> +		.compatible = "st,stm32f746-pinctrl",
> +		.data = &stm32f746_match_data,
> +	},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, stm32f746_pctrl_match);
  ^^^^^^^^^^^^^^^^^^^^

> +
> +static struct platform_driver stm32f746_pinctrl_driver = {
> +	.probe = stm32_pctl_probe,
> +	.driver = {
> +		.name = "stm32f746-pinctrl",
> +		.of_match_table = stm32f746_pctrl_match,
> +	},
> +};
> +
> +static int __init stm32f746_pinctrl_init(void)
> +{
> +	return platform_driver_register(&stm32f746_pinctrl_driver);
> +}
> +
> +module_init(stm32f746_pinctrl_init);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("STM32F746 Pinctrl Driver");
> +MODULE_AUTHOR("Maxime Coquelin <mcoquelin.stm32@gmail.com>");

...and here as well.  Please don't use modular support functions and
infrastructure for code that is only built-in.  Either make sure it can
be modular and use a tristate Kconfig, or delete all the MODULE_<tags>
and use device_initcall() to register the driver.

Thanks,
Paul.
--

> -- 
> 1.9.1
>