From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Michael Haas <michael.haas@mailbox.org>, Wens <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org,
robh+dt@kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux@armlinux.org.uk, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver
Date: Tue, 5 Jul 2016 14:43:17 +0200 [thread overview]
Message-ID: <20160705144317.4a654376@pluto.restena.lu> (raw)
In-Reply-To: <112861467708458@web7h.yandex.ru>
On Tue, 05 Jul 2016 16:47:38 +0800 Icenowy Zheng wrote:
> I read the datasheet of axp20x, and then found that this driver does
> not support backup RTC battery.
> (But maybe backup battery do not need a driver -- at least on IBM PC
> it has no driver)
A driver is needed to enable/disable the RTC battery charging (unless
uboot does it).
However all the driver can do according to datasheet is configure the
charge voltage/current or disable charging completely.
Monitoring RTC battery is not possible, neither is presence detection.
So driver should just apply configuration it finds in device-tree and
eventually share that information via power supply class.
> And I don't know whether the axp20x has default Li-ion/LiPo battery
> OCV parameter. (axp22x seems to be have a set of default OCV)
It seems to have default OCV parameters as well. With empty RTC
battery OCV values are present.
> You can test this driver on AXP20x. (I think I didn't access to
> AXP22x-specified registers in the power supply code)
Bruno
next prev parent reply other threads:[~2016-07-05 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160701092926.32005-1-icenowy@aosc.xyz>
[not found] ` <20160701092926.32005-2-icenowy@aosc.xyz>
2016-07-05 5:26 ` [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver Michael Haas
[not found] ` <4101467707611@web7h.yandex.ru>
2016-07-05 9:25 ` maxime.ripard
2016-07-05 12:45 ` Bruno Prémont
2016-07-06 4:34 ` Michael Haas
[not found] ` <112861467708458@web7h.yandex.ru>
2016-07-05 12:43 ` Bruno Prémont [this message]
2016-08-05 7:46 ` [PATCH 1/4] mfd: axp20x: add adc volatile ranges for axp22x Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705144317.4a654376@pluto.restena.lu \
--to=bonbons@linux-vserver.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=michael.haas@mailbox.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox