From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbcGESpb (ORCPT ); Tue, 5 Jul 2016 14:45:31 -0400 Received: from mail.skyhub.de ([78.46.96.112]:59288 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbcGESp3 (ORCPT ); Tue, 5 Jul 2016 14:45:29 -0400 Date: Tue, 5 Jul 2016 20:45:17 +0200 From: Borislav Petkov To: Steven Rostedt Cc: LKML , Andrew Morton , Franck Bui , Greg Kroah-Hartman , Ingo Molnar , Linus Torvalds , Peter Zijlstra , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release Message-ID: <20160705184517.GF12027@pd.tnic> References: <1467642292-15671-1-git-send-email-bp@alien8.de> <1467642292-15671-2-git-send-email-bp@alien8.de> <20160705142648.57456ef8@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160705142648.57456ef8@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 05, 2016 at 02:26:48PM -0400, Steven Rostedt wrote: > > + if (rs->missed) > > + printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n", > > + current->comm, rs->missed); > > Is the comm important? Yes, we wanna dump the task name which called devkmsg_release(). > Maybe add the function that called it? > > "%pS", _THIS_IP_ > > Perhaps add __always_inline, as _THIS_IP_ will point into the function > that calls this? That would inadvertently be devkmsg_release() in this use case. But we want to dump the task name which opened and spat so much crap into /dev/kmsg so as to cause the ratelimiting to hit. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.