From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751935AbcGFLgi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jul 2016 07:36:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46198 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751093AbcGFLgg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jul 2016 07:36:36 -0400
Date: Wed, 6 Jul 2016 13:36:15 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        lizefan@huawei.com, He Kuang <hekuang@huawei.com>,
        Jiri Olsa <jolsa@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Nilay Vaish <nilayvaish@gmail.com>
Subject: Re: [PATCH v13 2/8] perf evlist: Introduce aux evlist
Message-ID: <20160706113615.GB26517@krava>
References: <1467613209-191781-1-git-send-email-wangnan0@huawei.com>
 <1467613209-191781-3-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467613209-191781-3-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 06 Jul 2016 11:36:18 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 04, 2016 at 06:20:03AM +0000, Wang Nan wrote:

SNIP

> +struct perf_evlist *perf_evlist__new_aux(struct perf_evlist *parent)
> +{
> +	struct perf_evlist *evlist;
> +
> +	if (perf_evlist__is_aux(parent)) {
> +		pr_err("Internal error: create aux evlist from another aux evlist\n");
> +		return NULL;
> +	}
> +
> +	evlist = zalloc(sizeof(*evlist));
> +	if (!evlist)
> +		return NULL;
> +
> +	perf_evlist__init(evlist, parent->cpus, parent->threads);
> +	evlist->parent = parent;
> +	INIT_LIST_HEAD(&evlist->list);
> +	list_add(&evlist->list, &parent->children);

I understand there's some reason for separating maps with and
without overwrite set, but I'm missing it.. why is that?

thanks,
jirka