From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753858AbcGFKvV (ORCPT ); Wed, 6 Jul 2016 06:51:21 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:22199 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751178AbcGFKvT (ORCPT ); Wed, 6 Jul 2016 06:51:19 -0400 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: schwidefsky@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 6 Jul 2016 12:51:12 +0200 From: Martin Schwidefsky To: "Hillf Danton" Cc: "'linux-kernel'" , Subject: Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries In-Reply-To: <015d01d1d768$6db5d9e0$49218da0$@alibaba-inc.com> References: <014201d1d738$744c8f90$5ce5aeb0$@alibaba-inc.com> <014601d1d73b$5a3c0420$0eb40c60$@alibaba-inc.com> <20160706082350.5c56ca40@mschwide> <015301d1d751$8973de50$9c5b9af0$@alibaba-inc.com> <20160706104753.74daeaa2@mschwide> <015d01d1d768$6db5d9e0$49218da0$@alibaba-inc.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16070610-0024-0000-0000-000001ECF205 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16070610-0025-0000-0000-00001F867D59 Message-Id: <20160706125112.6cdf8262@mschwide> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-06_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607060096 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Jul 2016 17:26:08 +0800 "Hillf Danton" wrote: > > > > You are still a bit cryptic, > > > Sorry, Sir, simply because I'm not native English speaker. > > > are you trying to tell me that your hint is > > about trying to avoid the preempt_enable() call? > > > Yes, since we are already in the context with page table lock held. Ok, got it. An option would be to drop the preempt_disable/preempt_enable, add "BUG_ON(preemptible())" and use raw_smp_processor_id. But I wonder if it is worth the effort. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.