From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Wei Yongjun <weiyj_lk@163.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code
Date: Wed, 6 Jul 2016 15:34:44 +0200 [thread overview]
Message-ID: <20160706133444.GD3623@piout.net> (raw)
In-Reply-To: <8d02ef0b-f2d0-81c5-0048-36064f3e7955@163.com>
On 06/07/2016 at 21:19:34 +0800, Wei Yongjun wrote :
> Hi,
>
> On 07/06/2016 08:18 PM, Alexandre Belloni wrote:
> > Hi,
> >
> > On 06/07/2016 at 12:08:05 +0000, weiyj_lk@163.com wrote :
> >> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >>
> >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.
> >>
> > I'm guessing you found that using coccinnelle or any other static
> > analysis tool. Can you mention that in the commit message?
> >
> Your are right, this patch is found by coccinelle and created by scripts.
> (I called it dpatch, a kernel patch IDE, which had integrated coccinelle,
> sparse engine, scripts to found and create kernel patch.
> REF: https://github.com/weiyj/dpatch-devel).
>
> I mentioned those in passed, but no all of people like this.
>
Well it helps knowing whether this has been tested on actual hardware or
not.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-06 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 12:08 [PATCH -next] memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code weiyj_lk
2016-07-06 12:18 ` Alexandre Belloni
2016-07-06 13:19 ` Wei Yongjun
2016-07-06 13:34 ` Alexandre Belloni [this message]
2016-07-07 2:08 ` [PATCH -next v2] " weiyj_lk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706133444.GD3623@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=paul.gortmaker@windriver.com \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox